Skip to content
This repository
Browse code

Add Gemfile dependency for require_relative on mri18. This is a depen…

…dency of linecache which is a dependency of ruby-debug. However, the latest release of linecache (0.45) omits the dependency from its gemspec, causing the build to fail. I have emailed the maintainer so we should remove this when it's fixed upstream.
  • Loading branch information...
commit 954359b9c260f0e1265237c20bb3e4834a11fb9a 1 parent 190677d
Jon Leighton authored June 13, 2011

Showing 1 changed file with 3 additions and 0 deletions. Show diff stats Hide diff stats

  1. 3  Gemfile
3  Gemfile
@@ -26,6 +26,9 @@ gem "memcache-client", ">= 1.8.5"
26 26
 
27 27
 platforms :mri_18 do
28 28
   gem "system_timer"
  29
+  # ruby-debug requires linecache which depends on require_relative but doesn't explicitly
  30
+  # declare this in its gemspec
  31
+  gem "require_relative"
29 32
   gem "ruby-debug", ">= 0.10.3"
30 33
   gem "json"
31 34
 end

3 notes on commit 954359b

Arun Agrawal
Collaborator

@jonleighton How about downgrading linecache instead of using require_relative ??

#1671

Instead of loading new library and using new feature with older rubies we can stick with older version of linecache right??

These are my thoughts. Want to know your thoughts for this??

Hemant Kumar

No really, why are adding dependency of a library in Rails itself? shouldn't linecache specify its own dependency, rather than Rails adding stuff for it?

Jon Leighton
Owner

@arunagw I don't really see that one solution is more valid than the other. They both involve explicitly specifying a dependency of a dependency in our Gemfile. This works so I see no reason to change it.

@gnufied If you read the commit message you can see that I said I asked the maintainer of linecache to fix this so that we can remove this again. Also, this file does not specify the dependencies for the actual gems that get shipped, just the dependencies for running tests etc.

Please sign in to comment.
Something went wrong with that request. Please try again.