Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Merge pull request #10293 from vipulnsward/dont_mutate_callback

extract array to a constant
  • Loading branch information...
commit 95a2ccc0117c48725d296761dd025646406a6270 2 parents fae07a8 + d46cf35
@rafaelfranca rafaelfranca authored
Showing with 3 additions and 1 deletion.
  1. +3 −1 activesupport/lib/active_support/callbacks.rb
View
4 activesupport/lib/active_support/callbacks.rb
@@ -61,6 +61,8 @@ module Callbacks
extend ActiveSupport::DescendantsTracker
end
+ CALLBACK_FILTER_TYPES = [:before, :after, :around]
+
# Runs the callbacks for the given event.
#
# Calls the before and around callbacks in the order they were set, yields
@@ -396,7 +398,7 @@ def __callback_runner_name(kind)
# This is used internally to append, prepend and skip callbacks to the
# CallbackChain.
def __update_callbacks(name, filters = [], block = nil) #:nodoc:
- type = [:before, :after, :around].include?(filters.first) ? filters.shift : :before
+ type = CALLBACK_FILTER_TYPES.include?(filters.first) ? filters.shift : :before
options = filters.last.is_a?(Hash) ? filters.pop : {}
filters.unshift(block) if block
Please sign in to comment.
Something went wrong with that request. Please try again.