Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Eliminate Active Support warnings.

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4839 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
commit 965ae90bc6ff63c4aeee81cbc2137d8d7ef5ccdc 1 parent 06a731e
@jeremy jeremy authored
View
4 activesupport/Rakefile
@@ -18,7 +18,7 @@ task :default => :test
Rake::TestTask.new { |t|
t.pattern = 'test/**/*_test.rb'
t.verbose = true
- t.warning = false
+ t.warning = true
}
# Create compressed packages
@@ -79,4 +79,4 @@ task :release => [ :package ] do
puts release_command
system(release_command)
end
-end
+end
View
2  activesupport/lib/active_support.rb
@@ -39,4 +39,4 @@
require 'active_support/values/time_zone'
-require 'active_support/json'
+require 'active_support/json'
View
4 activesupport/lib/active_support/core_ext/module/attr_internal.rb
@@ -15,8 +15,8 @@ def attr_internal_writer(*attrs)
# Declare attributes backed by 'internal' instance variables names.
def attr_internal_accessor(*attrs)
- attr_internal_reader *attrs
- attr_internal_writer *attrs
+ attr_internal_reader(*attrs)
+ attr_internal_writer(*attrs)
end
alias_method :attr_internal, :attr_internal_accessor
View
1  activesupport/lib/active_support/deprecation.rb
@@ -18,6 +18,7 @@ def default_behavior
# Have deprecations been silenced?
def silenced?
+ @silenced = false unless defined?(@silenced)
@silenced
end
View
2  activesupport/lib/active_support/vendor/builder/xmlbase.rb
@@ -53,7 +53,7 @@ def method_missing(sym, *args, &block)
unless text.nil?
raise ArgumentError, "XmlMarkup cannot mix a text argument with a block"
end
- _capture_outer_self(block) if @self.nil?
+ _capture_outer_self(block) unless defined?(@self) && !@self.nil?
_indent
_start_tag(sym, attrs)
_newline
View
7 activesupport/test/core_ext/name_error_test.rb
@@ -1,8 +1,6 @@
-require 'test/unit'
-require File.dirname(__FILE__) + '/../../lib/active_support/core_ext/name_error'
+require File.dirname(__FILE__) + '/../abstract_unit'
class NameErrorTest < Test::Unit::TestCase
-
def test_name_error_should_set_missing_name
begin
SomeNameThatNobodyWillUse____Really ? 1 : 0
@@ -13,7 +11,7 @@ def test_name_error_should_set_missing_name
assert exc.missing_name?("NameErrorTest::SomeNameThatNobodyWillUse____Really")
end
end
-
+
def test_missing_method_should_ignore_missing_name
begin
some_method_that_does_not_exist
@@ -23,5 +21,4 @@ def test_missing_method_should_ignore_missing_name
assert ! exc.missing_name?(:Foo)
end
end
-
end
View
2  activesupport/test/core_ext/object_and_class_ext_test.rb
@@ -78,7 +78,7 @@ def test_extended_by
foo = Foo.new
assert foo.extended_by.include?(Bar)
foo.extend(Baz)
- assert ([Bar, Baz] - foo.extended_by).empty?, "Expected Bar, Baz in #{foo.extended_by.inspect}"
+ assert(([Bar, Baz] - foo.extended_by).empty?, "Expected Bar, Baz in #{foo.extended_by.inspect}")
end
def test_extend_with_included_modules_from

0 comments on commit 965ae90

Please sign in to comment.
Something went wrong with that request. Please try again.