Permalink
Browse files

hack around CGI session close

  • Loading branch information...
1 parent e9ae2b2 commit 977317da55b6ba9bbb1326392516480902145c5b @josh josh committed Aug 19, 2008
Showing with 5 additions and 1 deletion.
  1. +5 −1 actionpack/lib/action_controller/rack_process.rb
@@ -156,6 +156,10 @@ def status
end
def out(output = $stdout, &block)
+ # Nasty hack because CGI sessions are closed after the normal
+ # prepare! statement
+ set_cookies!
+
@block = block
@status = headers.delete("Status")
if [204, 304].include?(status.to_i)
@@ -200,7 +204,7 @@ def prepare!
convert_language!
convert_expires!
set_status!
- set_cookies!
+ # set_cookies!
@Manfred

Manfred Aug 20, 2008

Contributor

Josh, I think you accidentally left the commented out set_cookies call.

end
private

1 comment on commit 977317d

Member

josh commented on 977317d Aug 20, 2008

Yeah, thats not a diff bug either :)

I plan to revert this change (someday) if I can fiddle with the CGI session code without breaking anything on the CGI process side.

BTW, please test the Rack stuff out and ticket if you find any bugs. It needs to be “functional” by 2.2 or else it will be temporarily pulled.

Please sign in to comment.