Skip to content

Commit 97e7ca4

Browse files
committed
Deprecate unused symbolized_base_class and symbolized_sti_name.
These methods were only used for the `IdentityMap` which was removed. They are no longer used internally and should be removed without replacement. As they were not `:nodoc:`'ed it's better to deprecate them before removal.
1 parent 5aa8698 commit 97e7ca4

3 files changed

Lines changed: 10 additions & 0 deletions

File tree

activerecord/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
* Deprecate unused `ActiveRecord::Base.symbolized_base_class`
2+
and `ActiveRecord::Base.symbolized_sti_name` without replacement.
3+
4+
*Yves Senn*
5+
16
* Since the `test_help.rb` in Railties now automatically maintains
27
your test schema, the `rake db:test:*` tasks are deprecated. This
38
doesn't stop you manually running other tasks on your test database

activerecord/lib/active_record/inheritance.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,12 @@ def finder_needs_type_condition? #:nodoc:
4545
end
4646

4747
def symbolized_base_class
48+
ActiveSupport::Deprecation.warn("ActiveRecord::Base.symbolized_base_class is deprecated and will be removed without replacement.")
4849
@symbolized_base_class ||= base_class.to_s.to_sym
4950
end
5051

5152
def symbolized_sti_name
53+
ActiveSupport::Deprecation.warn("ActiveRecord::Base.symbolized_sti_name is deprecated and will be removed without replacement.")
5254
@symbolized_sti_name ||= sti_name.present? ? sti_name.to_sym : symbolized_base_class
5355
end
5456

guides/source/4_1_release_notes.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -432,6 +432,9 @@ for detailed changes.
432432
automatically maintained. See railties release notes. ([Pull
433433
Request](https://github.com/rails/rails/pull/13528))
434434

435+
* Deprecate unused `ActiveRecord::Base.symbolized_base_class`
436+
and `ActiveRecord::Base.symbolized_sti_name` without replacement.
437+
435438
### Notable changes
436439

437440
* Added `ActiveRecord::Base.to_param` for convenient "pretty" URLs derived from

0 commit comments

Comments
 (0)