Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Added ActiveRecord::Base.timestamps_gmt that can be set to true to ma…

…ke the automated timestamping use GMT instead of local time #520 [Scott Baron]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@491 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
commit 981d86cbb95303597488156cb12a0dcdc88f4cd5 1 parent 2257980
David Heinemeier Hansson dhh authored
2  activerecord/CHANGELOG
View
@@ -1,5 +1,7 @@
*SVN*
+* Added ActiveRecord::Base.timestamps_gmt that can be set to true to make the automated timestamping use GMT instead of local time #520 [Scott Baron]
+
* Added that update_all calls sanitize_sql on its updates argument, so stuff like MyRecord.update_all(['time = ?', Time.now]) works #519 [notahat]
* Fixed that the dynamic finders didn't treat nil as a "IS NULL" but rather "= NULL" case #515 [Demetrius]
19 activerecord/lib/active_record/timestamp.rb
View
@@ -4,6 +4,7 @@ module ActiveRecord
# automatically included, so you don't need to do that manually.
#
# This behavior can be turned off by setting <tt>ActiveRecord::Base.record_timestamps = false</tt>.
+ # This behavior can use GMT by setting <tt>ActiveRecord::Base.timestamps_gmt = true</tt>
module Timestamp
def self.append_features(base) # :nodoc:
super
@@ -18,18 +19,20 @@ def self.append_features(base) # :nodoc:
end
def create_with_timestamps
- write_attribute("created_at", Time.now) if record_timestamps && respond_to?(:created_at) && created_at.nil?
- write_attribute("created_on", Time.now) if record_timestamps && respond_to?(:created_on) && created_on.nil?
+ t = timestamps_gmt ? Time.now.gmtime : Time.now
+ write_attribute("created_at", t) if record_timestamps && respond_to?(:created_at) && created_at.nil?
+ write_attribute("created_on", t) if record_timestamps && respond_to?(:created_on) && created_on.nil?
- write_attribute("updated_at", Time.now) if record_timestamps && respond_to?(:updated_at)
- write_attribute("updated_on", Time.now) if record_timestamps && respond_to?(:updated_on)
+ write_attribute("updated_at", t) if record_timestamps && respond_to?(:updated_at)
+ write_attribute("updated_on", t) if record_timestamps && respond_to?(:updated_on)
create_without_timestamps
end
def update_with_timestamps
- write_attribute("updated_at", Time.now) if record_timestamps && respond_to?(:updated_at)
- write_attribute("updated_on", Time.now) if record_timestamps && respond_to?(:updated_on)
+ t = timestamps_gmt ? Time.now.gmtime : Time.now
+ write_attribute("updated_at", t) if record_timestamps && respond_to?(:updated_at)
+ write_attribute("updated_on", t) if record_timestamps && respond_to?(:updated_on)
update_without_timestamps
end
@@ -41,5 +44,7 @@ class Base
# if the table has columns of either of these names. This feature is turned on by default.
@@record_timestamps = true
cattr_accessor :record_timestamps
+ @@timestamps_gmt = false
+ cattr_accessor :timestamps_gmt
end
-end
+end
Please sign in to comment.
Something went wrong with that request. Please try again.