Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Add a :namespace option to AR::Base#to_xml [Koz]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5130 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
commit 98a412aa3853b9e31b747f53e58a841966df5f1b 1 parent 2caf4d5
@NZKoz NZKoz authored
View
2  activerecord/CHANGELOG
@@ -1,5 +1,7 @@
*SVN*
+* Add a :namespace option to AR::Base#to_xml [Koz]
+
* Deprecation tests. Remove warnings for dynamic finders and for the foo_count method if it's also an attribute. [Jeremy Kemper]
* Mock Time.now for more accurate Touch mixin tests. #6213 [Dan Peterson]
View
9 activerecord/lib/active_record/xml_serialization.rb
@@ -222,12 +222,17 @@ def add_tag(attribute)
end
def serialize
- builder.tag!(root) do
+ args = [root]
+ if options[:namespace]
+ args << {:xmlns=>options[:namespace]}
+ end
+
+ builder.tag!(*args) do
add_attributes
add_includes
add_procs
end
- end
+ end
alias_method :to_s, :serialize
View
8 activerecord/test/xml_serialization_test.rb
@@ -20,7 +20,13 @@ def test_should_serialize_default_root
assert_match %r{^<contact>}, @xml
assert_match %r{</contact>$}, @xml
end
-
+
+ def test_should_serialize_default_root_with_namespace
+ @xml = Contact.new.to_xml :namespace=>"http://xml.rubyonrails.org/contact"
+ assert_match %r{^<contact xmlns="http://xml.rubyonrails.org/contact">}, @xml
+ assert_match %r{</contact>$}, @xml
+ end
+
def test_should_serialize_custom_root
@xml = Contact.new.to_xml :root => 'xml_contact'
assert_match %r{^<xml-contact>}, @xml
Please sign in to comment.
Something went wrong with that request. Please try again.