Permalink
Browse files

config.ru uses the effective Rack app

We used to pass the Rails::Application subclass to #run.
The Rails server then called #to_app to convert that class to the
actual Rack application.

if you surround `#run` with a call to `#map` the server no longer
convertes the class to the instance and we end up with unnecessary
delegation calls on every request.
  • Loading branch information...
1 parent 5558bb0 commit 9b5c0850778207998a5cb8e5fe5bde6599af81d5 @senny senny committed Mar 11, 2013
@@ -42,6 +42,7 @@ def initialize(*)
set_environment
end
+ # TODO: this is no longer required but we keep it for the moment to support older config.ru files.
@claudiob

claudiob Jan 13, 2015

Member

@senny Do you think it's the right time to deprecate this?

@senny

senny Jan 14, 2015

Owner

@claudiob I think the timing would be good. How would you deprecate it?

def app
@app ||= begin
app = super
@@ -1,4 +1,4 @@
# This file is used by Rack-based servers to start the application.
require ::File.expand_path('../config/environment', __FILE__)
-run <%= app_const %>
+run Rails.application

0 comments on commit 9b5c085

Please sign in to comment.