Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Browse files

keep the build :green_heart:, #first on 1.8.7 and pg is different

The build only failed for ruby-1.8.7 and pg. The problem was that the statement:

author = Author.includes(:comments_with_order_and_conditions, :posts).first

resulted in Author with ID 2 where on all other rubies / db-engines Author with ID 1
was retunred. Of course this breaks the assertions.
  • Loading branch information...
commit 9be7f63db9063b004bc0645df1d49e23ee3ccae9 1 parent b4e053e
@senny senny authored
Showing with 1 addition and 1 deletion.
  1. +1 −1  activerecord/test/cases/associations/eager_test.rb
2  activerecord/test/cases/associations/eager_test.rb
@@ -1114,7 +1114,7 @@ def test_join_eager_with_nil_order_should_generate_valid_sql
test "preloading does not cache has many association subset when preloaded with a through association" do
- author = Author.includes(:comments_with_order_and_conditions, :posts).first
+ author = Author.where(:id => 1).includes(:comments_with_order_and_conditions, :posts).first
assert_no_queries { assert_equal 2, author.comments_with_order_and_conditions.size }
assert_no_queries { assert_equal 5, author.posts.size, "should not cache a subset of the association" }
Please sign in to comment.
Something went wrong with that request. Please try again.