Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Skip broken asset precompilation test on Macs. Issues with NFD vs NFC…

… normalization on the asset filename. Major red flag with asset lookups!
  • Loading branch information...
commit 9ce03d15428fee6f63e72a3de7b60f5e1ab8a97a 1 parent 0d0ded3
@jeremy jeremy authored
Showing with 8 additions and 4 deletions.
  1. +8 −4 railties/test/application/assets_test.rb
View
12 railties/test/application/assets_test.rb
@@ -289,16 +289,20 @@ class ::PostsController < ActionController::Base ; end
end
test "precompile should handle utf8 filenames" do
- app_file "app/assets/images/レイルズ.png", "not a image really"
+ if `uname` =~ /Darwin/
+ skip 'Asset lookup with Unicode filenames is a problematic due to different normalization forms. Mac uses NKD for filenames; Windows and Linux use NFC. So your asset lookups may mysteriously fail. Sprockets should handle these platform issues transparently.'
+ end
+
+ filename = "レイルズ.png"
+ app_file "app/assets/images/#{filename}", "not a image really"
add_to_config "config.assets.precompile = [ /\.png$$/, /application.(css|js)$/ ]"
precompile!
- assert File.exists?("#{app_path}/public/assets/レイルズ.png")
+ assert File.exists?("#{app_path}/public/assets/#{filename}")
manifest = "#{app_path}/public/assets/manifest.yml"
-
assets = YAML.load_file(manifest)
- assert_equal "レイルズ.png", assets["レイルズ.png"]
+ assert_equal filename, assets[filename], assets.inspect
end
test "assets are cleaned up properly" do
Please sign in to comment.
Something went wrong with that request. Please try again.