Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Remove 'parameters_for_url' parameter from 'form_tag' method signature

If you use that parameter it will end calling to url_for with two
arguments, which fails because url_for expects only one
  • Loading branch information...
commit 9e81bfd8fc8a35b28683b3e6b31cd2105b94bb55 1 parent d00e164
Gonzalo Rodriguez and Leonardo Capillera authored grzuy committed
Showing with 4 additions and 4 deletions.
  1. +4 −4 actionpack/lib/action_view/helpers/form_tag_helper.rb
View
8 actionpack/lib/action_view/helpers/form_tag_helper.rb
@@ -56,8 +56,8 @@ module FormTagHelper
# form_tag('http://far.away.com/form', :authenticity_token => "cf50faa3fe97702ca1ae")
# # form with custom authenticity token
#
- def form_tag(url_for_options = {}, options = {}, *parameters_for_url, &block)
- html_options = html_options_for_form(url_for_options, options, *parameters_for_url)
+ def form_tag(url_for_options = {}, options = {}, &block)
+ html_options = html_options_for_form(url_for_options, options)
if block_given?
form_tag_in_block(html_options, &block)
else
@@ -604,12 +604,12 @@ def utf8_enforcer_tag
end
private
- def html_options_for_form(url_for_options, options, *parameters_for_url)
+ def html_options_for_form(url_for_options, options)
options.stringify_keys.tap do |html_options|
html_options["enctype"] = "multipart/form-data" if html_options.delete("multipart")
# The following URL is unescaped, this is just a hash of options, and it is the
# responsibility of the caller to escape all the values.
- html_options["action"] = url_for(url_for_options, *parameters_for_url)
+ html_options["action"] = url_for(url_for_options)
html_options["accept-charset"] = "UTF-8"
html_options["data-remote"] = true if html_options.delete("remote")
html_options["authenticity_token"] = html_options.delete("authenticity_token") if html_options.has_key?("authenticity_token")
Please sign in to comment.
Something went wrong with that request. Please try again.