Browse files

Fix has_many assocation w/select load after create

If you create a new record via a collection association proxy that has
not loaded its target, and which selects additional attributes through
the association, then when the proxy loads its target, it will
inadvertently trigger an ActiveModel::MissingAttributeError during
attribute writing when CollectionAssociation#merge_target_lists attempts
to do its thing, since the newly loaded records will possess attributes
the created record does not.

This error also raises a bogus/confusing deprecation warning when
accessing the association in Rails 3.2.x, so cherry-pick would be
  • Loading branch information...
1 parent 2b83b07 commit 9f3b8cd5a5e37583bf9356456a3fc1b3484f4294 @ernie ernie committed Oct 5, 2012
@@ -414,7 +414,7 @@ def merge_target_lists(persisted, memory)! do |record|
if mem_record = memory.delete(record)
- (record.attribute_names - mem_record.changes.keys).each do |name|
+ ((record.attribute_names & mem_record.attribute_names) - mem_record.changes.keys).each do |name|
mem_record[name] = record[name]
@@ -231,6 +231,14 @@ def test_has_many_with_piggyback
assert_equal "2", categories(:sti_test).authors_with_select.first.post_id.to_s
+ def test_create_through_has_many_with_piggyback
+ category = categories(:sti_test)
+ ernie = category.authors_with_select.create(:name => 'Ernie')
+ assert_nothing_raised do
+ assert_equal ernie, category.authors_with_select.detect {|a| == 'Ernie'}
+ end
+ end
def test_include_has_many_through
posts = Post.all.merge!(:order => '').to_a
posts_with_authors = Post.all.merge!(:includes => :authors, :order => '').to_a

0 comments on commit 9f3b8cd

Please sign in to comment.