Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Deprecated add_on_boundary_breaking (use validates_length_of instead)…

… (closes #6292) [BobSilva]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5255 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
commit 9fd88d793998ea3a15a916ce7175f1bb2cd264fe 1 parent cb0837a
@dhh dhh authored
View
2  activerecord/CHANGELOG
@@ -1,5 +1,7 @@
*SVN*
+* Deprecated add_on_boundary_breaking (use validates_length_of instead) #6292 [BobSilva]
+
* The has_many create method works with polymorphic associations. #6361 [Dan Peterson]
* MySQL: introduce Mysql::Result#all_hashes to support further optimization. #5581 [Stefan Kaes]
View
1  activerecord/lib/active_record/validations.rb
@@ -87,6 +87,7 @@ def add_on_boundary_breaking(attributes, range, too_long_msg = @@default_error_m
end
alias :add_on_boundry_breaking :add_on_boundary_breaking
+ deprecate :add_on_boundary_breaking, :add_on_boundry_breaking
# Returns true if the specified +attribute+ has errors associated with it.
def invalid?(attribute)
View
6 activerecord/test/fixtures/company_in_module.rb
@@ -21,11 +21,7 @@ class Client < Company
class Developer < ActiveRecord::Base
has_and_belongs_to_many :projects
-
- protected
- def validate
- errors.add_on_boundary_breaking("name", 3..20)
- end
+ validates_length_of :name, :within => (3..20)
end
class Project < ActiveRecord::Base
View
25 activerecord/test/validations_test.rb
@@ -165,19 +165,6 @@ def test_validates_each
perform = false
end
- def test_errors_on_boundary_breaking
- developer = Developer.new("name" => "xs")
- assert !developer.save
- assert_equal "is too short (minimum is 3 characters)", developer.errors.on("name")
-
- developer.name = "All too very long for this boundary, it really is"
- assert !developer.save
- assert_equal "is too long (maximum is 20 characters)", developer.errors.on("name")
-
- developer.name = "Just right"
- assert developer.save
- end
-
def test_no_title_confirmation
Topic.validates_confirmation_of(:title)
@@ -626,6 +613,18 @@ def test_validates_length_with_globaly_modified_error_message
assert_equal 'tu est trops petit hombre 10', t.errors['title']
end
+
+ def test_add_on_boundary_breaking_is_deprecated
+ t = Topic.new('title' => 'noreplies', 'content' => 'whatever')
+ class << t
+ def validate
+ errors.add_on_boundary_breaking('title', 1..6)
+ end
+ end
+ assert_deprecated 'add_on_boundary_breaking' do
+ assert !t.valid?
+ end
+ end
def test_validates_size_of_association
assert_nothing_raised { Topic.validates_size_of :replies, :minimum => 1 }
Please sign in to comment.
Something went wrong with that request. Please try again.