Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Added :multipart option to ActiveRecordHelper#form to make it possibl…
…e to add file input fields #2034 [jstirk@oobleyboo.com]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2193 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information
dhh committed Sep 11, 2005
1 parent 8ae68ef commit a150687
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
2 changes: 2 additions & 0 deletions actionpack/CHANGELOG
@@ -1,5 +1,7 @@
*SVN*

* Added :multipart option to ActiveRecordHelper#form to make it possible to add file input fields #2034 [jstirk@oobleyboo.com]

* Moved auto-completion and in-place editing into the Macros module and their helper counterparts into JavaScriptMacrosHelper

* Added in-place editing support in the spirit of auto complete with ActionController::Base.in_place_edit_for, JavascriptHelper#in_place_editor_field, and Javascript support from script.aculo.us #2038 [Jon Tirsen]
Expand Down
2 changes: 1 addition & 1 deletion actionpack/lib/action_view/helpers/active_record_helper.rb
Expand Up @@ -71,7 +71,7 @@ def form(record_name, options = {})
yield contents if block_given?
contents << submit_tag(submit_value)

content_tag('form', contents, :action => action, :method => 'post')
content_tag('form', contents, :action => action, :method => 'post', :enctype => options[:multipart] ? 'multipart/form-data': nil)
end

# Returns a string containing the error message attached to the +method+ on the +object+, if one exists.
Expand Down
7 changes: 7 additions & 0 deletions actionpack/test/template/active_record_helper_test.rb
Expand Up @@ -119,4 +119,11 @@ def test_error_for_block
assert_equal %(<div class="errorExplanation" id="errorExplanation"><h2>1 error prohibited this post from being saved</h2><p>There were problems with the following fields:</p><ul><li>Author name can't be empty</li></ul></div>), error_messages_for("post")
assert_equal %(<div class="errorDeathByClass" id="errorDeathById"><h1>1 error prohibited this post from being saved</h1><p>There were problems with the following fields:</p><ul><li>Author name can't be empty</li></ul></div>), error_messages_for("post", :class => "errorDeathByClass", :id => "errorDeathById", :header_tag => "h1")
end

def test_form_with_string_multipart
assert_equal(
%(<form action="create" enctype="multipart/form-data" method="post"><p><label for="post_title">Title</label><br /><input id="post_title" name="post[title]" size="30" type="text" value="Hello World" /></p>\n<p><label for="post_body">Body</label><br /><div class="fieldWithErrors"><textarea cols="40" id="post_body" name="post[body]" rows="20">Back to the hill and over it again!</textarea></div></p><input name="commit" type="submit" value="Create" /></form>),
form("post", :multipart => true)
)
end
end

0 comments on commit a150687

Please sign in to comment.