Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Remove all deprecation warnings in activeresource

Signed-off-by: José Valim <jose.valim@gmail.com>
  • Loading branch information...
commit a18b73b43c07d031c9a660bc119835dcb6db85cf 1 parent 7204bb0
@carlosantoniodasilva carlosantoniodasilva authored josevalim committed
View
12 activeresource/lib/active_resource/validations.rb
@@ -68,16 +68,8 @@ module Validations
# Validate a resource and save (POST) it to the remote web service.
# If any local validations fail - the save (POST) will not be attempted.
- def save_with_validation(options=nil)
- perform_validation = case options
- when Hash
- options[:validate] != false
- when NilClass
- true
- else
- ActiveSupport::Deprecation.warn "save(#{options}) is deprecated, please give save(:validate => #{options}) instead", caller
- options
- end
+ def save_with_validation(options={})
+ perform_validation = options[:validate] != false
# clear the remote validations so they don't interfere with the local
# ones. Otherwise we get an endless loop and can never change the
View
8 activeresource/test/cases/validations_test.rb
@@ -36,14 +36,6 @@ def test_save_without_validation
assert p.save(:validate => false)
end
- def test_deprecated_save_without_validation
- p = new_project(:name => nil)
- assert !p.save
- assert_deprecated do
- assert p.save(false)
- end
- end
-
def test_validate_callback
# we have a callback ensuring the description is longer than three letters
p = new_project(:description => 'a')
Please sign in to comment.
Something went wrong with that request. Please try again.