Permalink
Browse files

test, use `columns_hash[]` in place of `columns.find {}`.

  • Loading branch information...
1 parent 096be96 commit a214bb71b2c4352d0c11abc8fcd354e88b6dcb62 @senny senny committed May 12, 2014
@@ -16,7 +16,7 @@ def setup
t.integer 'ratings', array: true
end
end
- @column = PgArray.columns.find { |c| c.name == 'tags' }
+ @column = PgArray.columns_hash['tags']
end
teardown do
@@ -64,7 +64,7 @@ def test_change_column_with_array
@connection.change_column :pg_arrays, :snippets, :text, array: true, default: []
PgArray.reset_column_information
- column = PgArray.columns.find { |c| c.name == 'snippets' }
+ column = PgArray.columns_hash['snippets']
assert_equal :text, column.type
assert_equal [], column.default
@@ -19,7 +19,7 @@ def setup
end
end
end
- @column = ByteaDataType.columns.find { |c| c.name == 'payload' }
+ @column = ByteaDataType.columns_hash['payload']
assert(@column.is_a?(ActiveRecord::ConnectionAdapters::PostgreSQLColumn))
end
@@ -50,7 +50,7 @@ def test_change_table_supports_json
t.citext 'username'
end
Citext.reset_column_information
- column = Citext.columns.find { |c| c.name == 'username' }
+ column = Citext.columns_hash['username']
assert_equal :citext, column.type
raise ActiveRecord::Rollback # reset the schema change
@@ -138,7 +138,7 @@ def test_money_values
end
def test_money_type_cast
- column = PostgresqlMoney.columns.find { |c| c.name == 'wealth' }
+ column = PostgresqlMoney.columns_hash['wealth']
assert_equal(12345678.12, column.type_cast("$12,345,678.12"))
assert_equal(12345678.12, column.type_cast("$12.345.678,12"))
assert_equal(-1.15, column.type_cast("-$1.15"))
@@ -28,7 +28,7 @@ def setup
t.hstore 'settings'
end
end
- @column = Hstore.columns.find { |c| c.name == 'tags' }
+ @column = Hstore.columns_hash['tags']
end
teardown do
@@ -78,7 +78,7 @@ def test_change_table_supports_hstore
t.hstore 'users', default: ''
end
Hstore.reset_column_information
- column = Hstore.columns.find { |c| c.name == 'users' }
+ column = Hstore.columns_hash['users']
assert_equal :hstore, column.type
raise ActiveRecord::Rollback # reset the schema change
@@ -23,7 +23,7 @@ def setup
rescue ActiveRecord::StatementInvalid
skip "do not test on PG without json"
end
- @column = JsonDataType.columns.find { |c| c.name == 'payload' }
+ @column = JsonDataType.columns_hash['payload']
end
teardown do
@@ -57,7 +57,7 @@ def test_change_table_supports_json
t.json 'users', default: '{}'
end
JsonDataType.reset_column_information
- column = JsonDataType.columns.find { |c| c.name == 'users' }
+ column = JsonDataType.columns_hash['users']
assert_equal :json, column.type
raise ActiveRecord::Rollback # reset the schema change
@@ -43,13 +43,13 @@ class UUIDType < ActiveRecord::Base
def test_change_column_default
@connection.add_column :uuid_data_type, :thingy, :uuid, null: false, default: "uuid_generate_v1()"
UUIDType.reset_column_information
- column = UUIDType.columns.find { |c| c.name == 'thingy' }
+ column = UUIDType.columns_hash['thingy']
assert_equal "uuid_generate_v1()", column.default_function
@connection.change_column :uuid_data_type, :thingy, :uuid, null: false, default: "uuid_generate_v4()"
UUIDType.reset_column_information
- column = UUIDType.columns.find { |c| c.name == 'thingy' }
+ column = UUIDType.columns_hash['thingy']
assert_equal "uuid_generate_v4()", column.default_function
ensure
UUIDType.reset_column_information
@@ -20,7 +20,7 @@ def setup
rescue ActiveRecord::StatementInvalid
skip "do not test on PG without xml"
end
- @column = XmlDataType.columns.find { |c| c.name == 'payload' }
+ @column = XmlDataType.columns_hash['payload']
end
teardown do

0 comments on commit a214bb7

Please sign in to comment.