Skip to content

Commit

Permalink
Remove deprecated ActiveSupport::Cache::Store.instrument
Browse files Browse the repository at this point in the history
  • Loading branch information
rafaelfranca committed Jan 4, 2015
1 parent c7a1fa3 commit a3ce6ca
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 14 deletions.
6 changes: 5 additions & 1 deletion activesupport/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
* Remove deprecated methods `ActiveSupport::Cache::Store.instrument` and
`ActiveSupport::Cache::Store.instrument=`.

*Rafael Mendonça França*

* Change the way in which callback chains can be halted.

The preferred method to halt a callback chain from now on is to explicitly
Expand All @@ -8,7 +13,6 @@
`Callbacks::CallbackChain.halt_and_display_warning_on_return_false`, will
either not work at all or display a deprecation warning.


* Add Callbacks::CallbackChain.halt_and_display_warning_on_return_false

Setting `Callbacks::CallbackChain.halt_and_display_warning_on_return_false`
Expand Down
13 changes: 0 additions & 13 deletions activesupport/lib/active_support/cache.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
require 'active_support/core_ext/numeric/time'
require 'active_support/core_ext/object/to_param'
require 'active_support/core_ext/string/inflections'
require 'active_support/deprecation'

module ActiveSupport
# See ActiveSupport::Cache::Store for documentation.
Expand Down Expand Up @@ -179,18 +178,6 @@ def mute
@silence = previous_silence
end

# :deprecated:
def self.instrument=(boolean)
ActiveSupport::Deprecation.warn "ActiveSupport::Cache.instrument= is deprecated and will be removed in Rails 5. Instrumentation is now always on so you can safely stop using it."
true
end

# :deprecated:
def self.instrument
ActiveSupport::Deprecation.warn "ActiveSupport::Cache.instrument is deprecated and will be removed in Rails 5. Instrumentation is now always on so you can safely stop using it."
true
end

# Fetches data from the cache, using the given key. If there is data in
# the cache with the given key, then that data is returned.
#
Expand Down

0 comments on commit a3ce6ca

Please sign in to comment.