Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Revert "Merge pull request #6084 from brainopia/support_for_magic_dom…

…ain_on_all_stores"

This reverts commit 393c652.

This commit was supposed to fix a bug but it add more failures.
  • Loading branch information...
commit a48ea6800ef712440b08c551f8041feb35de8cb4 1 parent 393c652
@rafaelfranca rafaelfranca authored
View
7 actionpack/lib/action_dispatch/middleware/session/abstract_store.rb
@@ -74,13 +74,6 @@ def stale_session_check!
class AbstractStore < Rack::Session::Abstract::ID
include Compatibility
include StaleSessionCheck
-
- private
-
- def set_cookie(env, session_id, cookie)
- request = ActionDispatch::Request.new(env)
- request.cookie_jar[key] = cookie
- end
end
end
end
View
7 actionpack/test/activerecord/active_record_store_test.rb
@@ -256,13 +256,6 @@ def test_incoming_invalid_session_id_via_parameter_should_be_ignored
end
end
- def test_session_store_with_all_domains
- with_test_route_set(:domain => :all) do
- get '/set_session_value'
- assert_response :success
- end
- end
-
private
def with_test_route_set(options = {})

3 comments on commit a48ea68

@brainopia

If you wish, I can find out why 3.2 branch does not work with the patch, since I've wrote this fix for the master – https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/middleware/session/abstract_store.rb#L84.

@rafaelfranca

@brainopia if you can please do it.

Please sign in to comment.
Something went wrong with that request. Please try again.