Permalink
Browse files

Revert "Merge pull request #6084 from brainopia/support_for_magic_dom…

…ain_on_all_stores"

This reverts commit 393c652.

This commit was supposed to fix a bug but it add more failures.
  • Loading branch information...
rafaelfranca committed Aug 5, 2012
1 parent 393c652 commit a48ea6800ef712440b08c551f8041feb35de8cb4
@@ -74,13 +74,6 @@ def stale_session_check!
class AbstractStore < Rack::Session::Abstract::ID
include Compatibility
include StaleSessionCheck
-
- private
-
- def set_cookie(env, session_id, cookie)
- request = ActionDispatch::Request.new(env)
- request.cookie_jar[key] = cookie
- end
end
end
end
@@ -256,13 +256,6 @@ def test_incoming_invalid_session_id_via_parameter_should_be_ignored
end
end
- def test_session_store_with_all_domains
- with_test_route_set(:domain => :all) do
- get '/set_session_value'
- assert_response :success
- end
- end
-
private
def with_test_route_set(options = {})

3 comments on commit a48ea68

@brainopia

This comment has been minimized.

Show comment Hide comment
@brainopia

brainopia Aug 6, 2012

Contributor

If you wish, I can find out why 3.2 branch does not work with the patch, since I've wrote this fix for the master – https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/middleware/session/abstract_store.rb#L84.

Contributor

brainopia replied Aug 6, 2012

If you wish, I can find out why 3.2 branch does not work with the patch, since I've wrote this fix for the master – https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/middleware/session/abstract_store.rb#L84.

@rafaelfranca

This comment has been minimized.

Show comment Hide comment
@rafaelfranca

rafaelfranca Aug 6, 2012

Member

@brainopia if you can please do it.

Member

rafaelfranca replied Aug 6, 2012

@brainopia if you can please do it.

@brainopia

This comment has been minimized.

Show comment Hide comment
@brainopia

brainopia Aug 10, 2012

Contributor
Contributor

brainopia replied Aug 10, 2012

Please sign in to comment.