Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Merge pull request #18260 from isaacseymour/active-job-delegate-deser…
…ialize ActiveJob: delegate deserialization to the job class
- Loading branch information
Showing
2 changed files
with
53 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,26 @@ | ||
* `ActiveJob::Base.deserialize` delegates to the job class | ||
|
||
Since `ActiveJob::Base#deserialize` can be overriden by subclasses (like `ActiveJob::Base#serialize`) | ||
this allows jobs to attach arbitrary metadata when they get serialized and read it back when they get | ||
performed. E.g. | ||
|
||
class DeliverWebhookJob < ActiveJob::Base | ||
def serialize | ||
super.merge('attempt_number' => (@attempt_number || 0) + 1) | ||
end | ||
|
||
def deserialize(job_data) | ||
super(job_data) | ||
@attempt_number = job_data['attempt_number'] | ||
end | ||
|
||
rescue_from(TimeoutError) do |ex| | ||
raise ex if @attempt_number > 5 | ||
retry_job(wait: 10) | ||
end | ||
end | ||
|
||
*Isaac Seymour* | ||
|
||
|
||
Please check [4-2-stable](https://github.com/rails/rails/blob/4-2-stable/activejob/CHANGELOG.md) for previous changes. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters