Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Tested FormHelper#label. Closes #9850 [jarkko]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8045 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
commit a55caf666cf4c00bdc5d73ac21ef92d6456cdf62 1 parent 4b63990
@jeremy jeremy authored
View
2  actionpack/CHANGELOG
@@ -103,7 +103,7 @@
* Fixed that setting the :host option in url_for would automatically turn off :only_path (since :host would otherwise not be shown) #9586 [Bounga]
-* Added FormHelper#label #8641 [jcoglan]
+* Added FormHelper#label. #8641, #9850 [jcoglan, jarkko]
* Added AtomFeedHelper (slightly improved from the atom_feed_helper plugin) [DHH]
View
10 actionpack/test/template/form_helper_test.rb
@@ -273,6 +273,10 @@ def test_explicit_id
def test_auto_index
pid = @post.id
assert_dom_equal(
+ "<label for=\"post_#{pid}_title\">Title</label>",
+ label("post[]", "title")
+ )
+ assert_dom_equal(
"<input id=\"post_#{pid}_title\" name=\"post[#{pid}][title]\" size=\"30\" type=\"text\" value=\"Hello World\" />", text_field("post[]","title")
)
assert_dom_equal(
@@ -361,6 +365,7 @@ def test_form_for_with_index
_erbout = ''
form_for("post[]", @post) do |f|
+ _erbout.concat f.label(:title)
_erbout.concat f.text_field(:title)
_erbout.concat f.text_area(:body)
_erbout.concat f.check_box(:secret)
@@ -368,6 +373,7 @@ def test_form_for_with_index
expected =
"<form action='http://www.example.com' method='post'>" +
+ "<label for=\"post_123_title\">Title</label>" +
"<input name='post[123][title]' size='30' type='text' id='post_123_title' value='Hello World' />" +
"<textarea name='post[123][body]' id='post_123_body' rows='20' cols='40'>Back to the hill and over it again!</textarea>" +
"<input name='post[123][secret]' checked='checked' type='checkbox' id='post_123_secret' value='1' />" +
@@ -430,10 +436,12 @@ def test_fields_for_without_object
def test_fields_for_object_with_bracketed_name
_erbout = ''
fields_for("author[post]", @post) do |f|
+ _erbout.concat f.label(:title)
_erbout.concat f.text_field(:title)
end
- assert_dom_equal "<input name='author[post][title]' size='30' type='text' id='author_post_title' value='Hello World' />",
+ assert_dom_equal "<label for=\"author_post_title\">Title</label>" +
+ "<input name='author[post][title]' size='30' type='text' id='author_post_title' value='Hello World' />",
_erbout
end
Please sign in to comment.
Something went wrong with that request. Please try again.