From 79cdc0c8f2f1eec102586b81cb7e5e46cd66ea23 Mon Sep 17 00:00:00 2001 From: Igor Drozdov Date: Wed, 5 Jul 2023 19:21:07 +0200 Subject: [PATCH 1/2] Add ruby2_keywords to ActionView::TestCase#method_missing For example RSpec predicate methods rely on method_missing. Without ruby2_keywords, matchers like be_something(kwarg: 1) don't work --- actionview/lib/action_view/test_case.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/actionview/lib/action_view/test_case.rb b/actionview/lib/action_view/test_case.rb index 59d9307a9c60f..a4ed44ceb1ec3 100644 --- a/actionview/lib/action_view/test_case.rb +++ b/actionview/lib/action_view/test_case.rb @@ -287,6 +287,7 @@ def method_missing(selector, *args) super end end + ruby2_keywords :method_missing def respond_to_missing?(name, include_private = false) begin From d540abd31badc6e8393eac379e520ffde2bfa17b Mon Sep 17 00:00:00 2001 From: Guillermo Iguaran Date: Wed, 5 Jul 2023 23:35:23 -0700 Subject: [PATCH 2/2] Add parentheses to ruby2_keywords method call For consistency with all the other usages of the method in the code base. --- actionview/lib/action_view/test_case.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/actionview/lib/action_view/test_case.rb b/actionview/lib/action_view/test_case.rb index a4ed44ceb1ec3..8f0d69ef77af5 100644 --- a/actionview/lib/action_view/test_case.rb +++ b/actionview/lib/action_view/test_case.rb @@ -287,7 +287,7 @@ def method_missing(selector, *args) super end end - ruby2_keywords :method_missing + ruby2_keywords(:method_missing) def respond_to_missing?(name, include_private = false) begin