Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Revert "prevent minitest from printing a --seed run option"

Reason: on a second thought, minitest prints a seed as run option
regardless of the test order, and it actually calls srand, so
albeit it might be misleading I believe, it is the way it is and
should be left that way.

This reverts commit c15862a.
  • Loading branch information...
commit a628dd5ac49987207f84c38c899900acb06abaaf 1 parent c15862a
@fxn fxn authored
Showing with 2 additions and 12 deletions.
  1. +2 −12 activesupport/lib/active_support/test_case.rb
View
14 activesupport/lib/active_support/test_case.rb
@@ -16,16 +16,6 @@
rescue LoadError
end
-# FIXME: We force sorted test order below, but minitest includes --seed SEED in
-# the printed run options, which could be misleading, since users could assume
-# from that trace that tests are being randomized.
-MiniTest::Unit.class_eval do
- alias original_help help
- def help
- original_help.sub(/--seed\s+\d+\s*/, '')
- end
-end
-
module ActiveSupport
class TestCase < ::MiniTest::Unit::TestCase
Assertion = MiniTest::Assertion
@@ -36,8 +26,8 @@ def self.for_tag(tag)
yield if $tags[tag]
end
- # FIXME: We have tests that depend on run order, we should fix that and
- # remove this method (and remove the MiniTest::Unit help hack above).
+ # FIXME: we have tests that depend on run order, we should fix that and
+ # remove this method.
def self.test_order # :nodoc:
:sorted
end
Please sign in to comment.
Something went wrong with that request. Please try again.