Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Merge pull request #10654 from schneems/schneems/fix-route-regression

Fix named routing regression from 3.2.13
  • Loading branch information...
commit a63074dde8363923f7d292eafca26ddb22f190db 2 parents 5dced4e + 2ee9a98
@rafaelfranca rafaelfranca authored
View
1  actionpack/lib/action_dispatch/routing/route_set.rb
@@ -218,6 +218,7 @@ def handle_positional_args(t, args, options, keys)
keys -= t.url_options.keys if t.respond_to?(:url_options)
keys -= options.keys
end
+ keys -= inner_options.keys
result.merge!(Hash[keys.zip(args)])
end
View
11 actionpack/test/dispatch/routing/route_set_test.rb
@@ -69,6 +69,17 @@ def call(env)
end
end
+ test "explicit keys win over implicit keys" do
+ draw do
+ resources :foo do
+ resources :bar, to: SimpleApp.new('foo#show')
+ end
+ end
+
+ assert_equal '/foo/1/bar/2', url_helpers.foo_bar_path(1, 2)
+ assert_equal '/foo/1/bar/2', url_helpers.foo_bar_path(2, foo_id: 1)
+ end
+
private
def clear!
@set.clear!
Please sign in to comment.
Something went wrong with that request. Please try again.