Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

r3569@asus: jeremy | 2005-09-26 05:33:09 -0700

 Ticket 1749 - reset_sequences workaround for non-integer sequences
 r3570@asus:  jeremy | 2005-09-26 08:30:30 -0700
 Fixtures.reset_sequences should only reset sequences corresponding to integer primary keys named id.  #1749
 r3571@asus:  jeremy | 2005-09-26 08:31:11 -0700
 Update change log.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2343 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
commit a68557952fd6caac526769beb699c7936cef001f 1 parent b2c46ed
@jeremy jeremy authored
View
2  activerecord/CHANGELOG
@@ -1,5 +1,7 @@
*SVN*
+* Fixtures should only reset a PostgreSQL sequence if it corresponds to an integer primary key named id. #1749 [chris@chrisbrinker.com]
+
* Standardize the interpretation of boolean columns in the Mysql and Sqlite adapters. (Use MysqlAdapter.emulate_booleans = false to disable this behavior)
* Added new symbol-driven approach to activating observers with Base#observers= [DHH]. Example:
View
12 activerecord/lib/active_record/fixtures.rb
@@ -246,15 +246,15 @@ def self.create_fixtures(fixtures_directory, *table_names)
end
end
- # Work around for PostgreSQL to have new fixtures created from id 1 and running.
+ # Start PostgreSQL fixtures at id 1. Skip tables without models
+ # and models with nonstandard primary keys.
def self.reset_sequences(connection, table_names)
table_names.flatten.each do |table|
- table_class = Inflector.classify(table.to_s)
- if Object.const_defined?(table_class)
- pk = eval("#{table_class}::primary_key")
- if pk == 'id'
+ if table_class = table.to_s.classify.constantize rescue nil
+ pk = table_class.columns_hash[table_class.primary_key]
+ if pk and pk.name == 'id' and pk.type == :integer
connection.execute(
- "SELECT setval('#{table.to_s}_id_seq', (SELECT MAX(id) FROM #{table.to_s}), true)",
+ "SELECT setval('#{table}_id_seq', (SELECT MAX(id) FROM #{table}), true)",
'Setting Sequence'
)
end
Please sign in to comment.
Something went wrong with that request. Please try again.