Permalink
Browse files

Partially revert 185fe2e

We shouldn't quote the unpack command's requirement as it's passed through GemRunner which takes care of it for us.
  • Loading branch information...
1 parent 025736d commit a78ec93036644c41f936128a2b6d52f3136ad64c @NZKoz NZKoz committed Sep 24, 2008
Showing with 4 additions and 2 deletions.
  1. +3 −1 railties/lib/rails/gem_dependency.rb
  2. +1 −1 railties/test/gem_dependency_test.rb
View
4 railties/lib/rails/gem_dependency.rb
@@ -120,7 +120,9 @@ def install_command
def unpack_command
cmd = %w(unpack) << @name
- cmd << "--version" << %("#{@requirement.to_s}") if @requirement
+ # We don't quote this requirement as it's run through GemRunner instead
+ # of shelling out to gem
+ cmd << "--version" << @requirement.to_s if @requirement
cmd
end
end
View
2 railties/test/gem_dependency_test.rb
@@ -37,7 +37,7 @@ def test_gem_creates_unpack_command
end
def test_gem_with_version_unpack_install_command
- assert_equal ["unpack", "hpricot", "--version", '"= 0.6"'], @gem_with_version.unpack_command
+ assert_equal ["unpack", "hpricot", "--version", '= 0.6'], @gem_with_version.unpack_command
end
def test_gem_adds_load_paths

0 comments on commit a78ec93

Please sign in to comment.