Permalink
Browse files

Don't destroy readonly models

  • Loading branch information...
1 parent 85ac143 commit a8b370f5c2fed87001e363d18ce60a47c1748885 @iGEL iGEL committed May 10, 2012
@@ -1,5 +1,10 @@
## Rails 4.0.0 (unreleased) ##
+* It's not possible anymore to destroy a model marked as read only.
+
+ *Johannes Barre*
+
+
* Added ability to ActiveRecord::Relation#from to accept other ActiveRecord::Relation objects
Record.from(subquery)
@@ -123,6 +123,7 @@ def delete
# Deletes the record in the database and freezes this instance to reflect
# that no changes should be made (since they can't be persisted).
def destroy
+ raise ReadOnlyRecord if readonly?
destroy_associations
destroy_row if persisted?
@destroyed = true
@@ -23,6 +23,7 @@ def test_cant_save_readonly_record
end
assert_raise(ActiveRecord::ReadOnlyRecord) { dev.save }
assert_raise(ActiveRecord::ReadOnlyRecord) { dev.save! }
+ assert_raise(ActiveRecord::ReadOnlyRecord) { dev.destroy }
end

0 comments on commit a8b370f

Please sign in to comment.