Permalink
Browse files

Fix #inspect for new records. Closes #8405.

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
1 parent 81ee044 commit a995b9cde074bec46ab4befc53f16ff91ec952f2 @jeremy jeremy committed May 19, 2007
Showing with 5 additions and 1 deletion.
  1. +1 −1 activerecord/lib/active_record/base.rb
  2. +4 −0 activerecord/test/base_test.rb
View
2 activerecord/lib/active_record/base.rb
@@ -1814,7 +1814,7 @@ def attributes_before_type_cast
# Format attributes nicely for inspect.
def attribute_for_inspect(attr_name)
- raise "Attribute not present #{attr_name}" unless has_attribute?(attr_name)
+ raise "Attribute not present #{attr_name}" unless has_attribute?(attr_name) || new_record?
value = read_attribute(attr_name)
if value.is_a?(String) && value.length > 50
View
4 activerecord/test/base_test.rb
@@ -1651,6 +1651,10 @@ def test_inspect
assert_equal topic.inspect, %(#<Topic id: 1, title: "The First Topic", author_name: "David", author_email_address: "david@loudthinking.com", written_on: "#{topic.written_on.to_s(:db)}", bonus_time: "#{topic.bonus_time.to_s(:db)}", last_read: "#{topic.last_read.to_s(:db)}", content: "Have a nice day", approved: false, replies_count: 1, parent_id: nil, type: nil>)
end
+ def test_inspect_new
+ assert_match /Topic id: nil/, Topic.new.inspect
+ end
+
def test_attribute_for_inspect
t = topics(:first)
t.content = %(This is some really long content, longer than 50 characters, so I can test that text is truncated correctly by the new ActiveRecord::Base#inspect method! Yay! BOOM!)

0 comments on commit a995b9c

Please sign in to comment.