Skip to content
Browse files

Calculate sum with SQL, not Enumerable on HasManyThrough Associations…

…. [Dan Peterson]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4640 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
1 parent d2eafa8 commit ab0277f22005b9690393318ef9adf94d815c1611 @technoweenie technoweenie committed Jul 31, 2006
View
2 activerecord/CHANGELOG
@@ -1,5 +1,7 @@
*SVN*
+* Calculate sum with SQL, not Enumerable on HasManyThrough Associations. [Dan Peterson]
+
* Factor the attribute#{suffix} methods out of method_missing for easier extension. [Jeremy Kemper]
* Patch sql injection vulnerability when using integer or float columns. [Jamis Buck]
View
7 activerecord/lib/active_record/associations/has_many_through_association.rb
@@ -47,7 +47,12 @@ def <<(*args)
[:push, :concat, :create, :build].each do |method|
alias_method method, :<<
end
-
+
+ # Calculate sum using SQL, not Enumerable
+ def sum(*args, &block)
+ calculate(:sum, *args, &block)
+ end
+
protected
def method_missing(method, *args, &block)
if @target.respond_to?(method) || (!@reflection.klass.respond_to?(method) && Class.respond_to?(method))
View
4 activerecord/test/associations_join_model_test.rb
@@ -370,6 +370,10 @@ def test_raise_error_when_adding_to_has_many_through
assert_raise(ActiveRecord::ReadOnlyAssociation) { posts(:thinking).tags.build(:name => 'foo') }
assert_raise(ActiveRecord::ReadOnlyAssociation) { posts(:thinking).tags.create(:name => 'foo') }
end
+
+ def test_has_many_through_sum_uses_calculations
+ assert_nothing_raised { authors(:david).comments.sum(:post_id) }
+ end
private
# create dynamic Post models to allow different dependency options

0 comments on commit ab0277f

Please sign in to comment.
Something went wrong with that request. Please try again.