Permalink
Browse files

Merge pull request #4911 from Floppy/master

Reduce FILENAME_MAX_SIZE in ActiveSupport::Cache::FileStore
  • Loading branch information...
tenderlove committed Mar 31, 2012
2 parents c3d482f + c33334f commit ad95a61b62e70b839567c2e91e127fc2a1acb113
Showing with 11 additions and 1 deletion.
  1. +1 −1 activesupport/lib/active_support/cache/file_store.rb
  2. +10 −0 activesupport/test/caching_test.rb
@@ -13,7 +13,7 @@ class FileStore < Store
attr_reader :cache_path
DIR_FORMATTER = "%03X"
- FILENAME_MAX_SIZE = 230 # max filename size on file system is 255, minus room for timestamp and random characters appended by Tempfile (used by atomic write)
+ FILENAME_MAX_SIZE = 228 # max filename size on file system is 255, minus room for timestamp and random characters appended by Tempfile (used by atomic write)
EXCLUDED_DIRS = ['.', '..'].freeze
def initialize(cache_path, options = nil)
@@ -579,6 +579,16 @@ def test_key_transformation_with_pathname
assert_equal "views/index?id=1", @cache_with_pathname.send(:file_path_key, key)
end
+ # Test that generated cache keys are short enough to have Tempfile stuff added to them and
+ # remain valid
+ def test_filename_max_size
+ key = "#{'A' * ActiveSupport::Cache::FileStore::FILENAME_MAX_SIZE}"
+ path = @cache.send(:key_file_path, key)
+ Dir::Tmpname.create(path) do |tmpname, n, opts|
+ assert (File.basename(tmpname+'.lock').length <= 255), "Temp filename too long: #{File.basename(tmpname+'.lock').length}"
+ end
+ end
+
# Because file systems have a maximum filename size, filenames > max size should be split in to directories
# If filename is 'AAAAB', where max size is 4, the returned path should be AAAA/B
def test_key_transformation_max_filename_size

0 comments on commit ad95a61

Please sign in to comment.