Permalink
Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Added #or to ActiveRecord::Relation
Post.where('id = 1').or(Post.where('id = 2')) # => SELECT * FROM posts WHERE (id = 1) OR (id = 2) [Matthew Draper & Gael Muller]
- Loading branch information
Showing
6 changed files
with
162 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
require "cases/helper" | ||
require 'models/post' | ||
|
||
module ActiveRecord | ||
class OrTest < ActiveRecord::TestCase | ||
fixtures :posts | ||
|
||
def test_or_with_relation | ||
expected = Post.where('id = 1 or id = 2').to_a | ||
assert_equal expected, Post.where('id = 1').or(Post.where('id = 2')).to_a | ||
end | ||
|
||
def test_or_identity | ||
expected = Post.where('id = 1').to_a | ||
assert_equal expected, Post.where('id = 1').or(Post.where('id = 1')).to_a | ||
end | ||
|
||
def test_or_with_null_left | ||
expected = Post.where('id = 1').to_a | ||
assert_equal expected, Post.none.or(Post.where('id = 1')).to_a | ||
end | ||
|
||
def test_or_with_null_right | ||
expected = Post.where('id = 1').to_a | ||
assert_equal expected, Post.where('id = 1').or(Post.none).to_a | ||
end | ||
|
||
def test_or_with_null_both | ||
expected = Post.none.to_a | ||
assert_equal expected, Post.none.or(Post.none).to_a | ||
end | ||
|
||
def test_or_without_left_where | ||
expected = Post.all.to_a | ||
assert_equal expected, Post.or(Post.where('id = 1')).to_a | ||
end | ||
|
||
def test_or_without_right_where | ||
expected = Post.all.to_a | ||
assert_equal expected, Post.where('id = 1').or(Post.all).to_a | ||
end | ||
|
||
def test_or_preserves_other_querying_methods | ||
expected = Post.where('id = 1 or id = 2 or id = 3').order('body asc').to_a | ||
partial = Post.order('body asc') | ||
assert_equal expected, partial.where('id = 1').or(partial.where(:id => [2, 3])).to_a | ||
assert_equal expected, Post.order('body asc').where('id = 1').or(Post.order('body asc').where(:id => [2, 3])).to_a | ||
end | ||
|
||
def test_or_with_incompatible_relations | ||
assert_raises ArgumentError do | ||
Post.order('body asc').where('id = 1').or(Post.order('id desc').where(:id => [2, 3])).to_a | ||
end | ||
end | ||
|
||
def test_or_when_grouping | ||
groups = Post.where('id < 10').group('body').select('body, COUNT(*) AS c') | ||
expected = groups.having("COUNT(*) > 1 OR body like 'Such%'").to_a.map {|o| [o.body, o.c] } | ||
assert_equal expected, groups.having('COUNT(*) > 1').or(groups.having("body like 'Such%'")).to_a.map {|o| [o.body, o.c] } | ||
end | ||
|
||
def test_or_with_named_scope | ||
expected = Post.where("id = 1 or body LIKE '\%a\%'").to_a | ||
assert_equal expected, Post.where('id = 1').or(Post.containing_the_letter_a) | ||
end | ||
|
||
def test_or_inside_named_scope | ||
expected = Post.where("body LIKE '\%a\%' OR title LIKE ?", "%'%").order('id DESC').to_a | ||
assert_equal expected, Post.order(id: :desc).typographically_interesting | ||
end | ||
|
||
def test_or_on_loaded_relation | ||
expected = Post.where('id = 1 or id = 2').to_a | ||
p = Post.where('id = 1') | ||
p.load | ||
assert_equal p.loaded?, true | ||
assert_equal expected, p.or(Post.where('id = 2')).to_a | ||
end | ||
|
||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is spawn here?