Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Add CHANGELOG entry for #11348

  • Loading branch information...
commit b18a27375a62b7c9848cd2dc7b5cf152ef61b62f 1 parent 9eeb3cc
@rafaelfranca rafaelfranca authored
Showing with 14 additions and 0 deletions.
  1. +14 −0 actionview/CHANGELOG.md
View
14 actionview/CHANGELOG.md
@@ -1,3 +1,17 @@
+* Fix `link_to` with block and url hashes.
+
+ Before:
+
+ link_to(action: 'bar', controller: 'foo') { content_tag(:span, 'Example site') }
+ # => "<a action=\"bar\" controller=\"foo\"><span>Example site</span></a>"
+
+ After:
+
+ link_to(action: 'bar', controller: 'foo') { content_tag(:span, 'Example site') }
+ # => "<a href=\"/\"><span>Example site</span></a>"
@egilburg
egilburg added a note

Shouldn't the example say something like <a href=\"/foo/bar\">...? Although it may be different with non-canonical routes, right now the example makes it seem like the url hash is being ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+
+ *Murahashi Sanemat Kenichi*
+
* Fix "Stack Level Too Deep" error when redering recursive partials.
Fixes #11340.
@egilburg

Shouldn't the example say something like <a href=\"/foo/bar\">...? Although it may be different with non-canonical routes, right now the example makes it seem like the url hash is being ignored.

Please sign in to comment.
Something went wrong with that request. Please try again.