Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Use better assertion methods for testing

[#4645 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
  • Loading branch information...
commit b4629528866446aa59f663a1162edbdacee85600 1 parent b753b4a
@neerajdotname neerajdotname authored josevalim committed
Showing with 116 additions and 123 deletions.
  1. +2 −2 actionmailer/test/base_test.rb
  2. +4 −4 actionmailer/test/old_base/asset_host_test.rb
  3. +1 −1  actionmailer/test/old_base/mail_render_test.rb
  4. +11 −11 actionmailer/test/old_base/mail_service_test.rb
  5. +2 −2 actionmailer/test/test_helper_test.rb
  6. +7 −7 actionpack/test/controller/filters_test.rb
  7. +2 −2 actionpack/test/controller/new_base/bare_metal_test.rb
  8. +1 −1  activemodel/test/cases/attribute_methods_test.rb
  9. +1 −1  activemodel/test/cases/callbacks_test.rb
  10. +2 −2 activemodel/test/cases/dirty_test.rb
  11. +1 −1  activemodel/test/cases/serializeration/xml_serialization_test.rb
  12. +10 −10 activerecord/test/cases/aggregations_test.rb
  13. +2 −2 activerecord/test/cases/associations/belongs_to_associations_test.rb
  14. +1 −1  activerecord/test/cases/associations/eager_load_includes_full_sti_class_test.rb
  15. +1 −1  activerecord/test/cases/associations/eager_test.rb
  16. +3 −10 activerecord/test/cases/associations/has_many_associations_test.rb
  17. +2 −2 activerecord/test/cases/associations/has_many_through_associations_test.rb
  18. +4 −4 activerecord/test/cases/associations/has_one_associations_test.rb
  19. +9 −9 activerecord/test/cases/associations/inverse_associations_test.rb
  20. +2 −2 activerecord/test/cases/associations/join_model_test.rb
  21. +1 −1  activerecord/test/cases/attribute_methods_test.rb
  22. +4 −4 activerecord/test/cases/autosave_association_test.rb
  23. +25 −25 activerecord/test/cases/base_test.rb
  24. +3 −3 activerecord/test/cases/column_definition_test.rb
  25. +2 −2 activerecord/test/cases/defaults_test.rb
  26. +2 −2 activerecord/test/cases/dirty_test.rb
  27. +11 −11 activerecord/test/cases/finder_respond_to_test.rb
View
4 actionmailer/test/base_test.rb
@@ -491,8 +491,8 @@ def give_a_greeting
# Class level API with method missing
test "should respond to action methods" do
- assert BaseMailer.respond_to?(:welcome)
- assert BaseMailer.respond_to?(:implicit_multipart)
+ assert_respond_to BaseMailer, :welcome
+ assert_respond_to BaseMailer, :implicit_multipart
assert !BaseMailer.respond_to?(:mail)
assert !BaseMailer.respond_to?(:headers)
end
View
8 actionmailer/test/old_base/asset_host_test.rb
@@ -26,7 +26,7 @@ def teardown
def test_asset_host_as_string
mail = AssetHostMailer.email_with_asset
- assert_equal "<img alt=\"Somelogo\" src=\"http://www.example.com/images/somelogo.png\" />", mail.body.to_s.strip
+ assert_equal %Q{<img alt="Somelogo" src="http://www.example.com/images/somelogo.png" />}, mail.body.to_s.strip
end
def test_asset_host_as_one_arguement_proc
@@ -38,7 +38,7 @@ def test_asset_host_as_one_arguement_proc
end
}
mail = AssetHostMailer.email_with_asset
- assert_equal "<img alt=\"Somelogo\" src=\"http://images.example.com/images/somelogo.png\" />", mail.body.to_s.strip
+ assert_equal %Q{<img alt="Somelogo" src="http://images.example.com/images/somelogo.png" />}, mail.body.to_s.strip
end
def test_asset_host_as_two_arguement_proc
@@ -51,6 +51,6 @@ def test_asset_host_as_two_arguement_proc
}
mail = nil
assert_nothing_raised { mail = AssetHostMailer.email_with_asset }
- assert_equal "<img alt=\"Somelogo\" src=\"http://www.example.com/images/somelogo.png\" />", mail.body.to_s.strip
+ assert_equal %Q{<img alt="Somelogo" src="http://www.example.com/images/somelogo.png" />}, mail.body.to_s.strip
end
-end
+end
View
2  actionmailer/test/old_base/mail_render_test.rb
@@ -117,7 +117,7 @@ def test_file_template
def test_rxml_template
mail = RenderMailer.rxml_template.deliver
- assert_equal "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<test/>", mail.body.to_s.strip
+ assert_equal %(<?xml version="1.0" encoding="UTF-8"?>\n<test/>), mail.body.to_s.strip
end
def test_included_subtemplate
View
22 actionmailer/test/old_base/mail_service_test.rb
@@ -281,7 +281,7 @@ def headers_with_nonalpha_chars(recipient)
from "One: Two <test@example.com>"
cc "Three: Four <test@example.com>"
bcc "Five: Six <test@example.com>"
- body "testing"
+ body "testing"
end
def custom_content_type_attributes
@@ -289,7 +289,7 @@ def custom_content_type_attributes
subject "custom content types"
from "some.one@somewhere.test"
content_type "text/plain; format=flowed"
- body "testing"
+ body "testing"
end
def return_path
@@ -297,7 +297,7 @@ def return_path
subject "return path test"
from "some.one@somewhere.test"
headers["return-path"] = "another@somewhere.test"
- body "testing"
+ body "testing"
end
def subject_with_i18n(recipient)
@@ -417,7 +417,7 @@ def test_signed_up
end
def test_custom_template
- expected = new_mail
+ expected = new_mail
expected.to = @recipient
expected.subject = "[Signed up] Welcome #{@recipient}"
expected.body = "Hello there, \n\nMr. #{@recipient}"
@@ -436,7 +436,7 @@ def test_custom_templating_extension
assert ActionView::Template.template_handler_extensions.include?("haml"), "haml extension was not registered"
# N.b., custom_templating_extension.text.plain.haml is expected to be in fixtures/test_mailer directory
- expected = new_mail
+ expected = new_mail
expected.to = @recipient
expected.subject = "[Signed up] Welcome #{@recipient}"
expected.body = "Hello there, \n\nMr. #{@recipient}"
@@ -453,7 +453,7 @@ def test_custom_templating_extension
end
def test_cancelled_account
- expected = new_mail
+ expected = new_mail
expected.to = @recipient
expected.subject = "[Cancelled] Goodbye #{@recipient}"
expected.body = "Goodbye, Mr. #{@recipient}"
@@ -477,7 +477,7 @@ def test_cancelled_account
end
def test_cc_bcc
- expected = new_mail
+ expected = new_mail
expected.to = @recipient
expected.subject = "testing bcc/cc"
expected.body = "Nothing to see here."
@@ -602,7 +602,7 @@ def test_iso_charset
def test_unencoded_subject
TestMailer.delivery_method = :test
- expected = new_mail
+ expected = new_mail
expected.to = @recipient
expected.subject = "testing unencoded subject"
expected.body = "Nothing to see here."
@@ -1151,15 +1151,15 @@ def teardown
end
def test_should_respond_to_new
- assert RespondToMailer.respond_to?(:new)
+ assert_respond_to RespondToMailer, :new
end
def test_should_respond_to_create_with_template_suffix
- assert RespondToMailer.respond_to?(:create_any_old_template)
+ assert_respond_to RespondToMailer, :create_any_old_template
end
def test_should_respond_to_deliver_with_template_suffix
- assert RespondToMailer.respond_to?(:deliver_any_old_template)
+ assert_respond_to RespondToMailer, :deliver_any_old_template
end
def test_should_not_respond_to_new_with_template_suffix
View
4 actionmailer/test/test_helper_test.rb
@@ -18,7 +18,7 @@ def test_setup_sets_right_action_mailer_options
end
def test_setup_creates_the_expected_mailer
- assert @expected.is_a?(Mail::Message)
+ assert_kind_of Mail::Message, @expected
assert_equal "1.0", @expected.mime_version
assert_equal "text/plain", @expected.mime_type
end
@@ -121,7 +121,7 @@ def setup
end
def test_setup_shouldnt_conflict_with_mailer_setup
- assert @expected.is_a?(Mail::Message)
+ assert_kind_of Mail::Message, @expected
assert_equal 'a value', @test_var
end
end
View
14 actionpack/test/controller/filters_test.rb
@@ -515,7 +515,7 @@ def test_running_anomolous_yet_valid_condition_filters
assert assigns["ran_proc_filter2"]
test_process(AnomolousYetValidConditionController, "show_without_filter")
- assert_equal nil, assigns["ran_filter"]
+ assert_nil assigns["ran_filter"]
assert !assigns["ran_class_filter"]
assert !assigns["ran_proc_filter1"]
assert !assigns["ran_proc_filter2"]
@@ -530,16 +530,16 @@ def test_running_collection_condition_filters
test_process(ConditionalCollectionFilterController)
assert_equal %w( ensure_login ), assigns["ran_filter"]
test_process(ConditionalCollectionFilterController, "show_without_filter")
- assert_equal nil, assigns["ran_filter"]
+ assert_nil assigns["ran_filter"]
test_process(ConditionalCollectionFilterController, "another_action")
- assert_equal nil, assigns["ran_filter"]
+ assert_nil assigns["ran_filter"]
end
def test_running_only_condition_filters
test_process(OnlyConditionSymController)
assert_equal %w( ensure_login ), assigns["ran_filter"]
test_process(OnlyConditionSymController, "show_without_filter")
- assert_equal nil, assigns["ran_filter"]
+ assert_nil assigns["ran_filter"]
test_process(OnlyConditionProcController)
assert assigns["ran_proc_filter"]
@@ -556,7 +556,7 @@ def test_running_except_condition_filters
test_process(ExceptConditionSymController)
assert_equal %w( ensure_login ), assigns["ran_filter"]
test_process(ExceptConditionSymController, "show_without_filter")
- assert_equal nil, assigns["ran_filter"]
+ assert_nil assigns["ran_filter"]
test_process(ExceptConditionProcController)
assert assigns["ran_proc_filter"]
@@ -573,7 +573,7 @@ def test_running_before_and_after_condition_filters
test_process(BeforeAndAfterConditionController)
assert_equal %w( ensure_login clean_up_tmp), assigns["ran_filter"]
test_process(BeforeAndAfterConditionController, "show_without_filter")
- assert_equal nil, assigns["ran_filter"]
+ assert_nil assigns["ran_filter"]
end
def test_around_filter
@@ -674,7 +674,7 @@ def test_condition_skipping_of_filters_when_siblings_also_have_conditions
def test_changing_the_requirements
test_process(ChangingTheRequirementsController, "go_wild")
- assert_equal nil, assigns['ran_filter']
+ assert_nil assigns['ran_filter']
end
def test_a_rescuing_around_filter
View
4 actionpack/test/controller/new_base/bare_metal_test.rb
@@ -18,10 +18,10 @@ class BareTest < ActiveSupport::TestCase
string << part
end
- assert headers.is_a?(Hash), "Headers must be a Hash"
+ assert_kind_of Hash, headers, "Headers must be a Hash"
assert headers["Content-Type"], "Content-Type must exist"
assert_equal "Hello world", string
end
end
-end
+end
View
2  activemodel/test/cases/attribute_methods_test.rb
@@ -31,7 +31,7 @@ class AttributeMethodsTest < ActiveModel::TestCase
ModelWithAttributes.define_attribute_methods([:foo])
assert ModelWithAttributes.attribute_methods_generated?
- assert ModelWithAttributes.new.respond_to?(:foo)
+ assert_respond_to ModelWithAttributes.new, :foo
assert_equal "value of foo", ModelWithAttributes.new.foo
end
View
2  activemodel/test/cases/callbacks_test.rb
@@ -65,6 +65,6 @@ def create
test "only selects which types of callbacks should be created" do
assert !ModelCallbacks.respond_to?(:before_initialize)
assert !ModelCallbacks.respond_to?(:around_initialize)
- assert ModelCallbacks.respond_to?(:after_initialize)
+ assert_respond_to ModelCallbacks, :after_initialize
end
end
View
4 activemodel/test/cases/dirty_test.rb
@@ -22,8 +22,8 @@ def name=(val)
test "changes accessible through both strings and symbols" do
model = DirtyModel.new
model.name = "David"
- assert !model.changes[:name].nil?
- assert !model.changes['name'].nil?
+ assert_not_nil model.changes[:name]
+ assert_not_nil model.changes['name']
end
end
View
2  activemodel/test/cases/serializeration/xml_serialization_test.rb
@@ -69,7 +69,7 @@ def setup
test "should allow skipped types" do
@xml = @contact.to_xml :skip_types => true
- assert %r{<age>25</age>}.match(@xml)
+ assert_match %r{<age>25</age>}, @xml
end
test "should include yielded additions" do
View
20 activerecord/test/cases/aggregations_test.rb
@@ -58,36 +58,36 @@ def test_reloaded_instance_refreshes_aggregations
end
def test_gps_equality
- assert GpsLocation.new('39x110') == GpsLocation.new('39x110')
+ assert_equal GpsLocation.new('39x110'), GpsLocation.new('39x110')
end
def test_gps_inequality
- assert GpsLocation.new('39x110') != GpsLocation.new('39x111')
+ assert_not_equal GpsLocation.new('39x110'), GpsLocation.new('39x111')
end
def test_allow_nil_gps_is_nil
- assert_equal nil, customers(:zaphod).gps_location
+ assert_nil customers(:zaphod).gps_location
end
def test_allow_nil_gps_set_to_nil
customers(:david).gps_location = nil
customers(:david).save
customers(:david).reload
- assert_equal nil, customers(:david).gps_location
+ assert_nil customers(:david).gps_location
end
def test_allow_nil_set_address_attributes_to_nil
customers(:zaphod).address = nil
- assert_equal nil, customers(:zaphod).attributes[:address_street]
- assert_equal nil, customers(:zaphod).attributes[:address_city]
- assert_equal nil, customers(:zaphod).attributes[:address_country]
+ assert_nil customers(:zaphod).attributes[:address_street]
+ assert_nil customers(:zaphod).attributes[:address_city]
+ assert_nil customers(:zaphod).attributes[:address_country]
end
def test_allow_nil_address_set_to_nil
customers(:zaphod).address = nil
customers(:zaphod).save
customers(:zaphod).reload
- assert_equal nil, customers(:zaphod).address
+ assert_nil customers(:zaphod).address
end
def test_nil_raises_error_when_allow_nil_is_false
@@ -104,9 +104,9 @@ def test_allow_nil_address_loaded_when_only_some_attributes_are_nil
def test_nil_assignment_results_in_nil
customers(:david).gps_location = GpsLocation.new('39x111')
- assert_not_equal nil, customers(:david).gps_location
+ assert_not_nil customers(:david).gps_location
customers(:david).gps_location = nil
- assert_equal nil, customers(:david).gps_location
+ assert_nil customers(:david).gps_location
end
def test_custom_constructor
View
4 activerecord/test/cases/associations/belongs_to_associations_test.rb
@@ -403,7 +403,7 @@ def test_polymorphic_assignment_updates_foreign_id_field_for_new_and_saved_recor
assert_equal saved_member.id, sponsor.sponsorable_id
sponsor.sponsorable = new_member
- assert_equal nil, sponsor.sponsorable_id
+ assert_nil sponsor.sponsorable_id
end
def test_polymorphic_assignment_with_primary_key_updates_foreign_id_field_for_new_and_saved_records
@@ -415,7 +415,7 @@ def test_polymorphic_assignment_with_primary_key_updates_foreign_id_field_for_ne
assert_equal saved_writer.name, essay.writer_id
essay.writer = new_writer
- assert_equal nil, essay.writer_id
+ assert_nil essay.writer_id
end
def test_belongs_to_proxy_should_not_respond_to_private_methods
View
2  activerecord/test/cases/associations/eager_load_includes_full_sti_class_test.rb
@@ -29,7 +29,7 @@ def test_class_names
ActiveRecord::Base.store_full_sti_class = true
post = Namespaced::Post.find_by_title( 'Great stuff', :include => :tagging )
- assert_equal 'Tagging', post.tagging.class.name
+ assert_instance_of Tagging, post.tagging
ensure
ActiveRecord::Base.store_full_sti_class = old
end
View
2  activerecord/test/cases/associations/eager_test.rb
@@ -110,7 +110,7 @@ def test_finding_with_includes_on_has_many_association_with_same_include_include
author = assert_queries(3) { Author.find(author_id, :include => {:posts_with_comments => :comments}) } # find the author, then find the posts, then find the comments
author.posts_with_comments.each do |post_with_comments|
assert_equal post_with_comments.comments.length, post_with_comments.comments.count
- assert_equal nil, post_with_comments.comments.uniq!
+ assert_nil post_with_comments.comments.uniq!
end
end
View
13 activerecord/test/cases/associations/has_many_associations_test.rb
@@ -175,14 +175,7 @@ def test_belongs_to_sanity
c = Client.new
assert_nil c.firm
- if c.firm
- assert false, "belongs_to failed if check"
- end
-
- unless c.firm
- else
- assert false, "belongs_to failed unless check"
- end
+ flunk "belongs_to failed if check" if c.firm
end
def test_find_ids
@@ -620,7 +613,7 @@ def test_clearing_an_exclusively_dependent_association_collection
assert_equal [], Client.destroyed_client_ids[firm.id]
# Should be destroyed since the association is exclusively dependent.
- assert Client.find_by_id(client_id).nil?
+ assert_nil Client.find_by_id(client_id)
end
def test_dependent_association_respects_optional_conditions_on_delete
@@ -669,7 +662,7 @@ def test_delete_all_association_with_primary_key_deletes_correct_records
old_record = firm.clients_using_primary_key_with_delete_all.first
firm = Firm.find(:first)
firm.destroy
- assert Client.find_by_id(old_record.id).nil?
+ assert_nil Client.find_by_id(old_record.id)
end
def test_creation_respects_hash_condition
View
4 activerecord/test/cases/associations/has_many_through_associations_test.rb
@@ -63,8 +63,8 @@ def test_associate_new_by_building
assert_queries(1) { posts(:thinking) }
assert_queries(0) do
- posts(:thinking).people.build(:first_name=>"Bob")
- posts(:thinking).people.new(:first_name=>"Ted")
+ posts(:thinking).people.build(:first_name => "Bob")
+ posts(:thinking).people.new(:first_name => "Ted")
end
# Should only need to load the association once
View
8 activerecord/test/cases/associations/has_one_associations_test.rb
@@ -149,7 +149,7 @@ def test_dependence
num_accounts = Account.count
firm = Firm.find(1)
- assert !firm.account.nil?
+ assert_not_nil firm.account
account_id = firm.account.id
assert_equal [], Account.destroyed_account_ids[firm.id]
@@ -162,7 +162,7 @@ def test_exclusive_dependence
num_accounts = Account.count
firm = ExclusivelyDependentFirm.find(9)
- assert !firm.account.nil?
+ assert_not_nil firm.account
account_id = firm.account.id
assert_equal [], Account.destroyed_account_ids[firm.id]
@@ -181,7 +181,7 @@ def test_dependence_with_restrict
firm = RestrictedFirm.new(:name => 'restrict')
firm.save!
account = firm.create_account(:credit_limit => 10)
- assert !firm.account.nil?
+ assert_not_nil firm.account
assert_raise(ActiveRecord::DeleteRestrictionError) { firm.destroy }
end
@@ -246,7 +246,7 @@ def test_create_before_save
def test_dependence_with_missing_association
Account.destroy_all
firm = Firm.find(1)
- assert firm.account.nil?
+ assert_nil firm.account
firm.destroy
end
View
18 activerecord/test/cases/associations/inverse_associations_test.rb
@@ -23,39 +23,39 @@ def test_should_allow_for_inverse_of_options_in_associations
def test_should_be_able_to_ask_a_reflection_if_it_has_an_inverse
has_one_with_inverse_ref = Man.reflect_on_association(:face)
- assert has_one_with_inverse_ref.respond_to?(:has_inverse?)
+ assert_respond_to has_one_with_inverse_ref, :has_inverse?
assert has_one_with_inverse_ref.has_inverse?
has_many_with_inverse_ref = Man.reflect_on_association(:interests)
- assert has_many_with_inverse_ref.respond_to?(:has_inverse?)
+ assert_respond_to has_many_with_inverse_ref, :has_inverse?
assert has_many_with_inverse_ref.has_inverse?
belongs_to_with_inverse_ref = Face.reflect_on_association(:man)
- assert belongs_to_with_inverse_ref.respond_to?(:has_inverse?)
+ assert_respond_to belongs_to_with_inverse_ref, :has_inverse?
assert belongs_to_with_inverse_ref.has_inverse?
has_one_without_inverse_ref = Club.reflect_on_association(:sponsor)
- assert has_one_without_inverse_ref.respond_to?(:has_inverse?)
+ assert_respond_to has_one_without_inverse_ref, :has_inverse?
assert !has_one_without_inverse_ref.has_inverse?
has_many_without_inverse_ref = Club.reflect_on_association(:memberships)
- assert has_many_without_inverse_ref.respond_to?(:has_inverse?)
+ assert_respond_to has_many_without_inverse_ref, :has_inverse?
assert !has_many_without_inverse_ref.has_inverse?
belongs_to_without_inverse_ref = Sponsor.reflect_on_association(:sponsor_club)
- assert belongs_to_without_inverse_ref.respond_to?(:has_inverse?)
+ assert_respond_to belongs_to_without_inverse_ref, :has_inverse?
assert !belongs_to_without_inverse_ref.has_inverse?
end
def test_should_be_able_to_ask_a_reflection_what_it_is_the_inverse_of
has_one_ref = Man.reflect_on_association(:face)
- assert has_one_ref.respond_to?(:inverse_of)
+ assert_respond_to has_one_ref, :inverse_of
has_many_ref = Man.reflect_on_association(:interests)
- assert has_many_ref.respond_to?(:inverse_of)
+ assert_respond_to has_many_ref, :inverse_of
belongs_to_ref = Face.reflect_on_association(:man)
- assert belongs_to_ref.respond_to?(:inverse_of)
+ assert_respond_to belongs_to_ref, :inverse_of
end
def test_inverse_of_method_should_supply_the_actual_reflection_instance_it_is_the_inverse_of
View
4 activerecord/test/cases/associations/join_model_test.rb
@@ -280,12 +280,12 @@ def test_has_many_with_hash_conditions
def test_has_many_find_conditions
assert_equal categories(:general), authors(:david).categories.find(:first, :conditions => "categories.name = 'General'")
- assert_equal nil, authors(:david).categories.find(:first, :conditions => "categories.name = 'Technology'")
+ assert_nil authors(:david).categories.find(:first, :conditions => "categories.name = 'Technology'")
end
def test_has_many_class_methods_called_by_method_missing
assert_equal categories(:general), authors(:david).categories.find_all_by_name('General').first
- assert_equal nil, authors(:david).categories.find_by_name('Technology')
+ assert_nil authors(:david).categories.find_by_name('Technology')
end
def test_has_many_array_methods_called_by_method_missing
View
2  activerecord/test/cases/attribute_methods_test.rb
@@ -310,7 +310,7 @@ def title; "private!"; end
end
assert !@target.instance_method_already_implemented?(:title)
topic = @target.new
- assert_equal nil, topic.title
+ assert_nil topic.title
Object.send(:undef_method, :title) # remove test method from object
end
View
8 activerecord/test/cases/autosave_association_test.rb
@@ -1236,11 +1236,11 @@ def setup
end
test "should generate validation methods for has_many associations" do
- assert @pirate.respond_to?(:validate_associated_records_for_birds)
+ assert_respond_to @pirate, :validate_associated_records_for_birds
end
test "should generate validation methods for has_one associations with :validate => true" do
- assert @pirate.respond_to?(:validate_associated_records_for_ship)
+ assert_respond_to @pirate, :validate_associated_records_for_ship
end
test "should not generate validation methods for has_one associations without :validate => true" do
@@ -1248,7 +1248,7 @@ def setup
end
test "should generate validation methods for belongs_to associations with :validate => true" do
- assert @pirate.respond_to?(:validate_associated_records_for_parrot)
+ assert_respond_to @pirate, :validate_associated_records_for_parrot
end
test "should not generate validation methods for belongs_to associations without :validate => true" do
@@ -1256,7 +1256,7 @@ def setup
end
test "should generate validation methods for HABTM associations with :validate => true" do
- assert @pirate.respond_to?(:validate_associated_records_for_parrots)
+ assert_respond_to @pirate, :validate_associated_records_for_parrots
end
test "should not generate validation methods for HABTM associations without :validate => true" do
View
50 activerecord/test/cases/base_test.rb
@@ -111,14 +111,14 @@ def test_set_attributes_with_block
def test_respond_to?
topic = Topic.find(1)
- assert topic.respond_to?("title")
- assert topic.respond_to?("title?")
- assert topic.respond_to?("title=")
- assert topic.respond_to?(:title)
- assert topic.respond_to?(:title?)
- assert topic.respond_to?(:title=)
- assert topic.respond_to?("author_name")
- assert topic.respond_to?("attribute_names")
+ assert_respond_to topic, "title"
+ assert_respond_to topic, "title?"
+ assert_respond_to topic, "title="
+ assert_respond_to topic, :title
+ assert_respond_to topic, :title?
+ assert_respond_to topic, :title=
+ assert_respond_to topic, "author_name"
+ assert_respond_to topic, "attribute_names"
assert !topic.respond_to?("nothingness")
assert !topic.respond_to?(:nothingness)
end
@@ -1038,9 +1038,9 @@ def test_mass_assignment_protection
def test_mass_assignment_protection_against_class_attribute_writers
[:logger, :configurations, :primary_key_prefix_type, :table_name_prefix, :table_name_suffix, :pluralize_table_names,
:default_timezone, :schema_format, :lock_optimistically, :record_timestamps].each do |method|
- assert Task.respond_to?(method)
- assert Task.respond_to?("#{method}=")
- assert Task.new.respond_to?(method)
+ assert_respond_to Task, method
+ assert_respond_to Task, "#{method}="
+ assert_respond_to Task.new, method
assert !Task.new.respond_to?("#{method}=")
end
end
@@ -1369,37 +1369,37 @@ def test_boolean_cast_from_string
end
def test_new_record_returns_boolean
- assert_equal Topic.new.new_record?, true
- assert_equal Topic.find(1).new_record?, false
+ assert_equal true, Topic.new.new_record?
+ assert_equal false, Topic.find(1).new_record?
end
def test_destroyed_returns_boolean
developer = Developer.first
- assert_equal developer.destroyed?, false
+ assert_equal false, developer.destroyed?
developer.destroy
- assert_equal developer.destroyed?, true
+ assert_equal true, developer.destroyed?
developer = Developer.last
- assert_equal developer.destroyed?, false
+ assert_equal false, developer.destroyed?
developer.delete
- assert_equal developer.destroyed?, true
+ assert_equal true, developer.destroyed?
end
def test_persisted_returns_boolean
developer = Developer.new(:name => "Jose")
- assert_equal developer.persisted?, false
+ assert_equal false, developer.persisted?
developer.save!
- assert_equal developer.persisted?, true
+ assert_equal true, developer.persisted?
developer = Developer.first
- assert_equal developer.persisted?, true
+ assert_equal true, developer.persisted?
developer.destroy
- assert_equal developer.persisted?, false
+ assert_equal false, developer.persisted?
developer = Developer.last
- assert_equal developer.persisted?, true
+ assert_equal true, developer.persisted?
developer.delete
- assert_equal developer.persisted?, false
+ assert_equal false, developer.persisted?
end
def test_clone
@@ -1427,7 +1427,7 @@ def test_clone
# test if saved clone object differs from original
cloned_topic.save
assert !cloned_topic.new_record?
- assert cloned_topic.id != topic.id
+ assert_not_equal cloned_topic.id, topic.id
end
def test_clone_with_aggregate_of_same_name_as_attribute
@@ -1447,7 +1447,7 @@ def test_clone_with_aggregate_of_same_name_as_attribute
assert clone.save
assert !clone.new_record?
- assert clone.id != dev.id
+ assert_not_equal clone.id, dev.id
end
def test_clone_preserves_subtype
View
6 activerecord/test/cases/column_definition_test.rb
@@ -71,17 +71,17 @@ def test_has_default_should_return_false_for_blog_and_test_data_types
if current_adapter?(:PostgreSQLAdapter)
def test_bigint_column_should_map_to_integer
bigint_column = ActiveRecord::ConnectionAdapters::PostgreSQLColumn.new('number', nil, "bigint")
- assert_equal bigint_column.type, :integer
+ assert_equal :integer, bigint_column.type
end
def test_smallint_column_should_map_to_integer
smallint_column = ActiveRecord::ConnectionAdapters::PostgreSQLColumn.new('number', nil, "smallint")
- assert_equal smallint_column.type, :integer
+ assert_equal :integer, smallint_column.type
end
def test_uuid_column_should_map_to_string
uuid_column = ActiveRecord::ConnectionAdapters::PostgreSQLColumn.new('unique_id', nil, "uuid")
- assert_equal uuid_column.type, :string
+ assert_equal :string, uuid_column.type
end
end
end
View
4 activerecord/test/cases/defaults_test.rb
@@ -67,8 +67,8 @@ def test_mysql_text_not_null_defaults
assert_equal '', klass.columns_hash['non_null_blob'].default
assert_equal '', klass.columns_hash['non_null_text'].default
- assert_equal nil, klass.columns_hash['null_blob'].default
- assert_equal nil, klass.columns_hash['null_text'].default
+ assert_nil klass.columns_hash['null_blob'].default
+ assert_nil klass.columns_hash['null_text'].default
assert_nothing_raised do
instance = klass.create!
View
4 activerecord/test/cases/dirty_test.rb
@@ -103,7 +103,7 @@ def test_time_attributes_changes_without_time_zone_by_skip
assert pirate.created_on_changed?
# kind_of does not work because
# ActiveSupport::TimeWithZone.name == 'Time'
- assert_equal Time, pirate.created_on_was.class
+ assert_instance_of Time, pirate.created_on_was
assert_equal old_created_on, pirate.created_on_was
end
end
@@ -132,7 +132,7 @@ def test_time_attributes_changes_without_time_zone
assert pirate.created_on_changed?
# kind_of does not work because
# ActiveSupport::TimeWithZone.name == 'Time'
- assert_equal Time, pirate.created_on_was.class
+ assert_instance_of Time, pirate.created_on_was
assert_equal old_created_on, pirate.created_on_was
end
View
22 activerecord/test/cases/finder_respond_to_test.rb
@@ -7,53 +7,53 @@ class FinderRespondToTest < ActiveRecord::TestCase
def test_should_preserve_normal_respond_to_behaviour_and_respond_to_newly_added_method
class << Topic; self; end.send(:define_method, :method_added_for_finder_respond_to_test) { }
- assert Topic.respond_to?(:method_added_for_finder_respond_to_test)
+ assert_respond_to Topic, :method_added_for_finder_respond_to_test
ensure
class << Topic; self; end.send(:remove_method, :method_added_for_finder_respond_to_test)
end
def test_should_preserve_normal_respond_to_behaviour_and_respond_to_standard_object_method
- assert Topic.respond_to?(:to_s)
+ assert_respond_to Topic, :to_s
end
def test_should_respond_to_find_by_one_attribute_before_caching
ensure_topic_method_is_not_cached(:find_by_title)
- assert Topic.respond_to?(:find_by_title)
+ assert_respond_to Topic, :find_by_title
end
def test_should_respond_to_find_all_by_one_attribute
ensure_topic_method_is_not_cached(:find_all_by_title)
- assert Topic.respond_to?(:find_all_by_title)
+ assert_respond_to Topic, :find_all_by_title
end
def test_should_respond_to_find_all_by_two_attributes
ensure_topic_method_is_not_cached(:find_all_by_title_and_author_name)
- assert Topic.respond_to?(:find_all_by_title_and_author_name)
+ assert_respond_to Topic, :find_all_by_title_and_author_name
end
def test_should_respond_to_find_by_two_attributes
ensure_topic_method_is_not_cached(:find_by_title_and_author_name)
- assert Topic.respond_to?(:find_by_title_and_author_name)
+ assert_respond_to Topic, :find_by_title_and_author_name
end
def test_should_respond_to_find_or_initialize_from_one_attribute
ensure_topic_method_is_not_cached(:find_or_initialize_by_title)
- assert Topic.respond_to?(:find_or_initialize_by_title)
+ assert_respond_to Topic, :find_or_initialize_by_title
end
def test_should_respond_to_find_or_initialize_from_two_attributes
ensure_topic_method_is_not_cached(:find_or_initialize_by_title_and_author_name)
- assert Topic.respond_to?(:find_or_initialize_by_title_and_author_name)
+ assert_respond_to Topic, :find_or_initialize_by_title_and_author_name
end
def test_should_respond_to_find_or_create_from_one_attribute
ensure_topic_method_is_not_cached(:find_or_create_by_title)
- assert Topic.respond_to?(:find_or_create_by_title)
+ assert_respond_to Topic, :find_or_create_by_title
end
def test_should_respond_to_find_or_create_from_two_attributes
ensure_topic_method_is_not_cached(:find_or_create_by_title_and_author_name)
- assert Topic.respond_to?(:find_or_create_by_title_and_author_name)
+ assert_respond_to Topic, :find_or_create_by_title_and_author_name
end
def test_should_not_respond_to_find_by_one_missing_attribute
@@ -73,4 +73,4 @@ def ensure_topic_method_is_not_cached(method_id)
class << Topic; self; end.send(:remove_method, method_id) if Topic.public_methods.any? { |m| m.to_s == method_id.to_s }
end
-end
+end
Please sign in to comment.
Something went wrong with that request. Please try again.