Permalink
Browse files

Added graceful handling of an inaccessible log file by redirecting ou…

…tput to STDERR with a warning #330 [rainmkr]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@223 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
1 parent 3b56b85 commit b586c7a97ab7b2b7bf9fde4710e10ca3343a2e3f @dhh dhh committed Dec 19, 2004
Showing with 25 additions and 3 deletions.
  1. +3 −1 railties/CHANGELOG
  2. +11 −1 railties/environments/shared.rb
  3. +11 −1 railties/environments/shared_for_gem.rb
View
@@ -1,8 +1,10 @@
*SVN*
+* Added graceful handling of an inaccessible log file by redirecting output to STDERR with a warning #330 [rainmkr]
+
* Added support for a -h/--help parameter in the generator #331 [Ulysses]
-* File.expand_path in config/environment.rb would fail when dealing with symlinked public directories [mjobin].
+* File.expand_path in config/environment.rb would fail when dealing with symlinked public directories [mjobin]
*0.9.1*
@@ -41,7 +41,17 @@
# Configure defaults if the included environment did not.
-RAILS_DEFAULT_LOGGER = Logger.new("#{RAILS_ROOT}/log/#{RAILS_ENV}.log")
+begin
+ RAILS_DEFAULT_LOGGER = Logger.new("#{RAILS_ROOT}/log/#{RAILS_ENV}.log")
+rescue StandardError
+ RAILS_DEFAULT_LOGGER = Logger.new(STDERR)
+ RAILS_DEFAULT_LOGGER.level = Logger::WARN
+ RAILS_DEFAULT_LOGGER.warn(
+ "Rails Error: Unable to access log file. Please ensure that log/#{RAILS_ENV}.log exists and is chmod 0777. " +
+ "The log level has been raised to WARN and the output directed to STDERR until the problem is fixed."
+ )
+end
+
[ActiveRecord::Base, ActionController::Base, ActionMailer::Base].each do |klass|
klass.logger ||= RAILS_DEFAULT_LOGGER
end
@@ -38,7 +38,17 @@
# Configure defaults if the included environment did not.
-RAILS_DEFAULT_LOGGER = Logger.new("#{RAILS_ROOT}/log/#{RAILS_ENV}.log")
+begin
+ RAILS_DEFAULT_LOGGER = Logger.new("#{RAILS_ROOT}/log/#{RAILS_ENV}.log")
+rescue StandardError
+ RAILS_DEFAULT_LOGGER = Logger.new(STDERR)
+ RAILS_DEFAULT_LOGGER.level = Logger::WARN
+ RAILS_DEFAULT_LOGGER.warn(
+ "Rails Error: Unable to access log file. Please ensure that log/#{RAILS_ENV}.log exists and is chmod 0777. " +
+ "The log level has been raised to WARN and the output directed to STDERR until the problem is fixed."
+ )
+end
+
[ActiveRecord::Base, ActionController::Base, ActionMailer::Base].each do |klass|
klass.logger ||= RAILS_DEFAULT_LOGGER
end

0 comments on commit b586c7a

Please sign in to comment.