Permalink
Browse files

Merge pull request #25015 from joemasilotti/patch-1

Add notes on cosmetic patches to contributing guidelines
  • Loading branch information...
eileencodes committed May 13, 2016
2 parents 0991c4c + 6143de0 commit b6429b871ff8b73ebd10076ead6ed2c1f651da86
Showing with 4 additions and 0 deletions.
  1. +4 −0 CONTRIBUTING.md
View
@@ -21,6 +21,10 @@
* Before submitting, please read the [Contributing to Ruby on Rails](http://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html) guide to know more about coding conventions and benchmarks.
+#### **Did you fix whitespace, format code, or make a purely cosmetic patch?**
+
+Changes that are cosmetic in nature and do not add anything substantial to the stability, functionality, or testability of Rails will generally not be accepted (read more about [our rationales behind this decision](https://github.com/rails/rails/pull/13771#issuecomment-32746700)).
+
#### **Do you intend to add a new feature or change an existing one?**
* Suggest your change in the [rubyonrails-core mailing list](https://groups.google.com/forum/?fromgroups#!forum/rubyonrails-core) and start writing code.

0 comments on commit b6429b8

Please sign in to comment.