Permalink
Browse files

Fix `bin/rails db:forward` first migration

  • Loading branch information...
bogdanvlviv committed Feb 25, 2017
1 parent c324f5d commit b77d2aa0c336492ba33cbfade4964ba0eda3ef84
@@ -1,3 +1,7 @@
* Fix `bin/rails db:forward` first migration.
*bogdanvlviv*
* Support Descending Indexes for MySQL.
MySQL 8.0.1 and higher supports descending indexes: `DESC` in an index definition is no longer ignored.
@@ -1104,7 +1104,13 @@ def migration_files(paths)
def move(direction, migrations_paths, steps)
migrator = new(direction, migrations(migrations_paths))
start_index = migrator.migrations.index(migrator.current_migration)
start_index =
if current_version == 0
0
else
migrator.migrations.index(migrator.current_migration)
end
if start_index
finish = migrator.migrations[start_index + steps]
@@ -142,6 +142,31 @@ class AMigration < ActiveRecord::Migration::Current
end
end
test "migration status after rollback and forward" do
Dir.chdir(app_path) do
`bin/rails generate model user username:string password:string;
bin/rails generate migration add_email_to_users email:string;
bin/rails db:migrate`
output = `bin/rails db:migrate:status`
assert_match(/up\s+\d{14}\s+Create users/, output)
assert_match(/up\s+\d{14}\s+Add email to users/, output)
`bin/rails db:rollback STEP=2`
output = `bin/rails db:migrate:status`
assert_match(/down\s+\d{14}\s+Create users/, output)
assert_match(/down\s+\d{14}\s+Add email to users/, output)
`bin/rails db:forward STEP=2`
output = `bin/rails db:migrate:status`
assert_match(/up\s+\d{14}\s+Create users/, output)
assert_match(/up\s+\d{14}\s+Add email to users/, output)
end
end
test "migration status after rollback and redo without timestamps" do
add_to_config("config.active_record.timestamped_migrations = false")

0 comments on commit b77d2aa

Please sign in to comment.