Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Make RUBY_PLATFORM windows regex consistent [#4345 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
  • Loading branch information...
commit b9b9f9ee15e2282e9c765d86cb8b6120e2bdb1b9 1 parent 3eda7cf
@anildigital anildigital authored josevalim committed
Showing with 1 addition and 1 deletion.
  1. +1 −1  railties/lib/rails/commands/runner.rb
View
2  railties/lib/rails/commands/runner.rb
@@ -18,7 +18,7 @@
opts.on("-h", "--help",
"Show this help message.") { $stderr.puts opts; exit }
- if RUBY_PLATFORM !~ /mswin/
+ if RUBY_PLATFORM !~ /(:?mswin|mingw)/
@paddor
paddor added a note

Shouldn't it be /(?:mswin|mingw)/ or just /mswin|mingw/ ?

@fxn Owner
fxn added a note

yeah, the latter is better, grouping is superfluous in that regexp

@jeremy Owner
jeremy added a note

fixed 4d09832

also updated in other places 518891f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
opts.separator ""
opts.separator "You can also use runner as a shebang line for your scripts like this:"
opts.separator "-------------------------------------------------------------"
Please sign in to comment.
Something went wrong with that request. Please try again.