Browse files

Make RUBY_PLATFORM windows regex consistent [#4345 state:resolved]

Signed-off-by: José Valim <>
  • Loading branch information...
1 parent 3eda7cf commit b9b9f9ee15e2282e9c765d86cb8b6120e2bdb1b9 @anildigital anildigital committed with josevalim Apr 8, 2010
Showing with 1 addition and 1 deletion.
  1. +1 −1 railties/lib/rails/commands/runner.rb
2 railties/lib/rails/commands/runner.rb
@@ -18,7 +18,7 @@
opts.on("-h", "--help",
"Show this help message.") { $stderr.puts opts; exit }
- if RUBY_PLATFORM !~ /mswin/
+ if RUBY_PLATFORM !~ /(:?mswin|mingw)/
paddor added a line comment Apr 13, 2010

Shouldn't it be /(?:mswin|mingw)/ or just /mswin|mingw/ ?

Ruby on Rails member
fxn added a line comment Apr 13, 2010

yeah, the latter is better, grouping is superfluous in that regexp

Ruby on Rails member
jeremy added a line comment Apr 13, 2010

fixed 4d09832

anildigital added a line comment Apr 13, 2010

also updated in other places 518891f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
opts.separator ""
opts.separator "You can also use runner as a shebang line for your scripts like this:"
opts.separator "-------------------------------------------------------------"

0 comments on commit b9b9f9e

Please sign in to comment.