Skip to content
Browse files

Merge pull request #8678 from yahonda/remove_column_oracle

Address a failure test_remove_column_with_multi_column_index with Oracle
  • Loading branch information...
2 parents e333d64 + e7ff765 commit baf8e34697b38f2ebbf1f868ac950da767d319a5 @rafaelfranca rafaelfranca committed Jan 1, 2013
Showing with 3 additions and 2 deletions.
  1. +3 −2 activerecord/test/cases/migration/rename_column_test.rb
View
5 activerecord/test/cases/migration/rename_column_test.rb
@@ -107,8 +107,9 @@ def test_remove_column_with_multi_column_index
assert_equal 1, connection.indexes('test_models').size
remove_column("test_models", "hat_size")
- # FIXME: should all adapters behave the same?
- if current_adapter?(:PostgreSQLAdapter)
+ # Every database and/or database adapter has their own behavior
+ # if it drops the multi-column index when any of the indexed columns dropped by remove_column.
+ if current_adapter?(:PostgreSQLAdapter, :OracleAdapter)
assert_equal [], connection.indexes('test_models').map(&:name)
else
assert_equal ['index_test_models_on_hat_style_and_hat_size'], connection.indexes('test_models').map(&:name)

0 comments on commit baf8e34

Please sign in to comment.
Something went wrong with that request. Please try again.