From bc9060a22a84ecb8a1fb2645c60957ef81e5d810 Mon Sep 17 00:00:00 2001 From: weavermedia Date: Fri, 7 Jan 2022 10:32:03 -0800 Subject: [PATCH] Improve ActiveStorage analyzer error message for missing ffprobe. Add mention to guides. --- activestorage/lib/active_storage/analyzer/audio_analyzer.rb | 2 +- activestorage/lib/active_storage/analyzer/video_analyzer.rb | 2 +- guides/source/active_storage_overview.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/activestorage/lib/active_storage/analyzer/audio_analyzer.rb b/activestorage/lib/active_storage/analyzer/audio_analyzer.rb index 0cd9badfa934c..4fe9be9203603 100644 --- a/activestorage/lib/active_storage/analyzer/audio_analyzer.rb +++ b/activestorage/lib/active_storage/analyzer/audio_analyzer.rb @@ -54,7 +54,7 @@ def probe_from(file) end end rescue Errno::ENOENT - logger.info "Skipping audio analysis because FFmpeg isn't installed" + logger.info "Skipping audio analysis because ffprobe isn't installed" {} end diff --git a/activestorage/lib/active_storage/analyzer/video_analyzer.rb b/activestorage/lib/active_storage/analyzer/video_analyzer.rb index 7f22a58abe9be..d870f1f035409 100644 --- a/activestorage/lib/active_storage/analyzer/video_analyzer.rb +++ b/activestorage/lib/active_storage/analyzer/video_analyzer.rb @@ -133,7 +133,7 @@ def probe_from(file) end end rescue Errno::ENOENT - logger.info "Skipping video analysis because FFmpeg isn't installed" + logger.info "Skipping video analysis because ffprobe isn't installed" {} end diff --git a/guides/source/active_storage_overview.md b/guides/source/active_storage_overview.md index 3b2d00b40a359..a55ddd7f265d6 100644 --- a/guides/source/active_storage_overview.md +++ b/guides/source/active_storage_overview.md @@ -38,7 +38,7 @@ Various features of Active Storage depend on third-party software which Rails will not install, and must be installed separately: * [libvips](https://github.com/libvips/libvips) v8.6+ or [ImageMagick](https://imagemagick.org/index.php) for image analysis and transformations -* [ffmpeg](http://ffmpeg.org/) v3.4+ for video/audio analysis and video previews +* [ffmpeg](http://ffmpeg.org/) v3.4+ for video previews and ffprobe for video/audio analysis * [poppler](https://poppler.freedesktop.org/) or [muPDF](https://mupdf.com/) for PDF previews Image analysis and transformations also require the `image_processing` gem. Uncomment it in your `Gemfile`, or add it if necessary: