Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Calling ActiveRecord#inspect on an unloaded association won't wipe th…

…e collection [#9 state:resolved]

Signed-off-by: Joshua Peek <josh@joshpeek.com>
  • Loading branch information...
commit bcb090c56b842a76397e0ea32f54c942fd11910e 1 parent 2561732
@zargony zargony authored josh committed
View
4 activerecord/lib/active_record/associations/association_proxy.rb
@@ -118,7 +118,7 @@ def target=(target)
end
def inspect
- reload unless loaded?
+ load_target
@target.inspect
end
@@ -167,7 +167,7 @@ def merge_options_from_reflection!(options)
def with_scope(*args, &block)
@reflection.klass.send :with_scope, *args, &block
end
-
+
private
def method_missing(method, *args)
if load_target
View
6 activerecord/test/cases/associations_test.rb
@@ -149,6 +149,12 @@ def test_save_on_parent_does_not_load_target
assert !david.projects.loaded?
end
+ def test_inspect_does_not_reload_a_not_yet_loaded_target
+ andreas = Developer.new :name => 'Andreas', :log => 'new developer added'
+ assert !andreas.audit_logs.loaded?
+ assert_match(/message: "new developer added"/, andreas.audit_logs.inspect)
+ end
+
def test_save_on_parent_saves_children
developer = Developer.create :name => "Bryan", :salary => 50_000
assert_equal 1, developer.reload.audit_logs.size
View
4 activerecord/test/models/developer.rb
@@ -49,6 +49,10 @@ def find_least_recent
before_create do |developer|
developer.audit_logs.build :message => "Computer created"
end
+
+ def log=(message)
+ audit_logs.build :message => message
+ end
end
class AuditLog < ActiveRecord::Base

0 comments on commit bcb090c

Please sign in to comment.
Something went wrong with that request. Please try again.