Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Ensure AR#sum result is typecasted properly

  • Loading branch information...
commit bd75a722a2e9f979bfd1b1d89442e4dd6f3e3af7 1 parent 952ec79
@lifo lifo authored
View
5 activerecord/lib/active_record/calculations.rb
@@ -265,8 +265,9 @@ def column_for(field)
def type_cast_calculated_value(value, column, operation = nil)
operation = operation.to_s.downcase
case operation
- when 'count', 'sum' then value.to_i
- when 'avg' then value && value.to_f
+ when 'count' then value.to_i
+ when 'sum' then value =~ /\./ ? value.to_f : value.to_i
+ when 'avg' then value && value.to_f
else column ? column.type_cast(value) : value
end
end
View
5 activerecord/test/cases/calculations_test.rb
@@ -102,6 +102,11 @@ def test_should_return_zero_if_sum_conditions_return_nothing
assert_equal 0, companies(:rails_core).companies.sum(:id, :conditions => '1 = 2')
end
+ def test_sum_should_return_valid_values_for_decimals
+ NumericData.create(:bank_balance => 19.83)
+ assert_equal 19.83, NumericData.sum(:bank_balance)
+ end
+
def test_should_group_by_summed_field_with_conditions
c = Account.sum(:credit_limit, :conditions => 'firm_id > 1',
:group => :firm_id)
Please sign in to comment.
Something went wrong with that request. Please try again.