Skip to content
This repository
Browse code

Disable active record marshalling tests on Ruby 1.8.7 on Travis CI, a…

…s they have been failing intermittently for a long while due to what appears to be a Ruby bug. If anyone has the skills/expertise/time to debug this, please speak to the Travis guys.
  • Loading branch information...
commit bf2779298b24fced9602345a3cd80f2714e79b06 1 parent 679a4eb
Jon Leighton jonleighton authored
10 activerecord/test/cases/associations/extension_test.rb
@@ -36,6 +36,11 @@ def test_extension_with_scopes
36 36 end
37 37
38 38 def test_marshalling_extensions
  39 + if ENV['TRAVIS'] && RUBY_VERSION == "1.8.7"
  40 + return skip("Marshalling tests disabled for Ruby 1.8.7 on Travis CI due to what appears " \
  41 + "to be a Ruby bug.")
  42 + end
  43 +
39 44 david = developers(:david)
40 45 assert_equal projects(:action_controller), david.projects.find_most_recent
41 46
@@ -46,6 +51,11 @@ def test_marshalling_extensions
46 51 end
47 52
48 53 def test_marshalling_named_extensions
  54 + if ENV['TRAVIS'] && RUBY_VERSION == "1.8.7"
  55 + return skip("Marshalling tests disabled for Ruby 1.8.7 on Travis CI due to what appears " \
  56 + "to be a Ruby bug.")
  57 + end
  58 +
49 59 david = developers(:david)
50 60 assert_equal projects(:action_controller), david.projects_extended_by_name.find_most_recent
51 61
15 activerecord/test/cases/base_test.rb
@@ -1834,6 +1834,11 @@ def test_current_scope_is_reset
1834 1834 end
1835 1835
1836 1836 def test_marshal_round_trip
  1837 + if ENV['TRAVIS'] && RUBY_VERSION == "1.8.7"
  1838 + return skip("Marshalling tests disabled for Ruby 1.8.7 on Travis CI due to what appears " \
  1839 + "to be a Ruby bug.")
  1840 + end
  1841 +
1837 1842 expected = posts(:welcome)
1838 1843 marshalled = Marshal.dump(expected)
1839 1844 actual = Marshal.load(marshalled)
@@ -1842,6 +1847,11 @@ def test_marshal_round_trip
1842 1847 end
1843 1848
1844 1849 def test_marshal_new_record_round_trip
  1850 + if ENV['TRAVIS'] && RUBY_VERSION == "1.8.7"
  1851 + return skip("Marshalling tests disabled for Ruby 1.8.7 on Travis CI due to what appears " \
  1852 + "to be a Ruby bug.")
  1853 + end
  1854 +
1845 1855 marshalled = Marshal.dump(Post.new)
1846 1856 post = Marshal.load(marshalled)
1847 1857
@@ -1849,6 +1859,11 @@ def test_marshal_new_record_round_trip
1849 1859 end
1850 1860
1851 1861 def test_marshalling_with_associations
  1862 + if ENV['TRAVIS'] && RUBY_VERSION == "1.8.7"
  1863 + return skip("Marshalling tests disabled for Ruby 1.8.7 on Travis CI due to what appears " \
  1864 + "to be a Ruby bug.")
  1865 + end
  1866 +
1852 1867 post = Post.new
1853 1868 post.comments.build
1854 1869

0 comments on commit bf27792

Please sign in to comment.
Something went wrong with that request. Please try again.