Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Revert "Added Enumerable#pluck to wrap the common pattern of collect(…

…&:method) *DHH*"

This reverts commit 4d20de8.
  • Loading branch information...
commit c0563cec6d87adafa99e3b86356c0e912e00030e 1 parent 1945baf
Aaron Patterson tenderlove authored
6 activesupport/CHANGELOG.md
View
@@ -1,9 +1,7 @@
## Rails 3.2.0 (unreleased) ##
-* Added Enumerable#pluck to wrap the common pattern of collect(&:method) *DHH*
-
-* Module#synchronize is deprecated with no replacement. Please use `monitor`
- from ruby's standard library.
+* Module#synchronize is deprecated with no replacement. Please use `monitor`
+ from ruby's standard library.
* (Date|DateTime|Time)#beginning_of_week accept an optional argument to
be able to set the day at which weeks are assumed to start.
7 activesupport/lib/active_support/core_ext/enumerable.rb
View
@@ -63,13 +63,6 @@ def sum(identity = 0, &block)
end
end
- # Plucks the value of the passed method for each element and returns the result as an array. Example:
- #
- # people.pluck(:name) # => [ "David Heinemeier Hansson", "Jamie Heinemeier Hansson" ]
- def pluck(method)
- collect { |element| element.send(method) }
- end
-
# Iterates over a collection, passing the current element *and* the
# +memo+ to the block. Handy for building up hashes or
# reducing collections down to one object. Examples:
9 activesupport/test/core_ext/enumerable_test.rb
View
@@ -126,11 +126,4 @@ def test_exclude?
assert_equal true, GenericEnumerable.new([ 1 ]).exclude?(2)
assert_equal false, GenericEnumerable.new([ 1 ]).exclude?(1)
end
-
- def test_pluck_single_method
- person = Struct.new(:name)
- people = [ person.new("David"), person.new("Jamie") ]
-
- assert_equal [ "David", "Jamie" ], people.pluck(:name)
- end
-end
+end

1 comment on commit c0563ce

Erik Peterson

This commit is my favorite commit.

Please sign in to comment.
Something went wrong with that request. Please try again.