Skip to content
Browse files

User.each is a lie

  • Loading branch information...
1 parent 19d9997 commit c30f6c270da5cd2ad7605ee9255f052e93609e30 @lifo lifo committed Aug 30, 2010
Showing with 2 additions and 2 deletions.
  1. +2 −2 railties/guides/source/active_record_querying.textile
View
4 railties/guides/source/active_record_querying.textile
@@ -159,14 +159,14 @@ The following may seem very straight forward at first:
<ruby>
# Very inefficient when users table has thousands of rows.
-User.each do |user|
+User.all.each do |user|
NewsLetter.weekly_deliver(user)
end
</ruby>
But if the total number of rows in the table is very large, the above approach may vary from being under performant to just plain impossible.
-This is because +User.each+ makes Active Record fetch _the entire table_, build a model object per row, and keep the entire array in the memory. Sometimes that is just too many objects and demands too much memory.
+This is because +User.all.each+ makes Active Record fetch _the entire table_, build a model object per row, and keep the entire array in the memory. Sometimes that is just too many objects and demands too much memory.
h5. +find_each+

1 comment on commit c30f6c2

@sikachu
Ruby on Rails member

With Portal theme? :D

Watch out for GLaDOS!

Please sign in to comment.
Something went wrong with that request. Please try again.