Browse files

Merge pull request #7371 from csmuc/fix_dup_validation_errors

Dup'ed ActiveRecord objects may not share the errors object
  • Loading branch information...
2 parents 12a0383 + fb66521 commit c432c74cd34d4230bfda6fa008f2af9dbc33e523 @spastorino spastorino committed Oct 16, 2012
Showing with 20 additions and 0 deletions.
  1. +5 −0 activerecord/CHANGELOG.md
  2. +1 −0 activerecord/lib/active_record/timestamp.rb
  3. +14 −0 activerecord/test/cases/dup_test.rb
View
5 activerecord/CHANGELOG.md
@@ -288,6 +288,11 @@
*Ari Pollak*
+* Fix AR#dup to nullify the validation errors in the dup'ed object. Previously the original
+ and the dup'ed object shared the same errors.
+
+ * Christian Seiler*
+
* Raise `ArgumentError` if list of attributes to change is empty in `update_all`.
*Roman Shatsov*
View
1 activerecord/lib/active_record/timestamp.rb
@@ -42,6 +42,7 @@ module Timestamp
def initialize_dup(other) # :nodoc:
clear_timestamp_attributes
+ super
end
private
View
14 activerecord/test/cases/dup_test.rb
@@ -107,5 +107,19 @@ def test_dup_after_initialize_callbacks
assert Topic.after_initialize_called
end
+ def test_dup_validity_is_independent
+ Topic.validates_presence_of :title
+ topic = Topic.new("title" => "Litterature")
+ topic.valid?
+
+ duped = topic.dup
+ duped.title = nil
+ assert duped.invalid?
+
+ topic.title = nil
+ duped.title = 'Mathematics'
+ assert topic.invalid?
+ assert duped.valid?
+ end
end
end

0 comments on commit c432c74

Please sign in to comment.