Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
It's snowing!
  • Loading branch information
jeremy committed Aug 12, 2010
1 parent fddcd21 commit c49144b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion actionpack/lib/action_view/helpers/form_tag_helper.rb
Expand Up @@ -538,7 +538,7 @@ def html_options_for_form(url_for_options, options, *parameters_for_url)

def extra_tags_for_form(html_options)
snowman_tag = tag(:input, :type => "hidden",
:name => "utf8", :value => "✓".html_safe)
:name => "_utf8", :value => "☃".html_safe)

method = html_options.delete("method").to_s

Expand Down
2 changes: 1 addition & 1 deletion actionpack/test/template/form_helper_test.rb
Expand Up @@ -1513,7 +1513,7 @@ def test_form_for_with_labelled_builder

def snowman(method = nil)
txt = %{<div style="margin:0;padding:0;display:inline">}
txt << %{<input name="utf8" type="hidden" value="&#x2713;" />}
txt << %{<input name="_utf8" type="hidden" value="&#9731;" />}
txt << %{<input name="_method" type="hidden" value="#{method}" />} if method
txt << %{</div>}
end
Expand Down
2 changes: 1 addition & 1 deletion actionpack/test/template/form_tag_helper_test.rb
Expand Up @@ -12,7 +12,7 @@ def snowman(options = {})
method = options[:method]

txt = %{<div style="margin:0;padding:0;display:inline">}
txt << %{<input name="utf8" type="hidden" value="&#x2713;" />}
txt << %{<input name="_utf8" type="hidden" value="&#9731;" />}
txt << %{<input name="_method" type="hidden" value="#{method}" />} if method
txt << %{</div>}
end
Expand Down

12 comments on commit c49144b

@iain
Copy link
Contributor

@iain iain commented on c49144b Aug 12, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snowman is back! :) ☃

@norman
Copy link
Contributor

@norman norman commented on c49144b Aug 12, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice call. :)

@Aupajo
Copy link
Contributor

@Aupajo Aupajo commented on c49144b Aug 13, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! http://railssnowman.info has been updated :)

@seban
Copy link

@seban seban commented on c49144b Aug 13, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good morning news

@jimneath
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! ☃!

@teamon
Copy link

@teamon teamon commented on c49144b Aug 13, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update information about parameter name (I`d leave _snowman :P)

And, btw, could it be an option? (So it could be disabled in test env since rack-test don`t like that)

@plukevdh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rock on ☃!

@alan
Copy link
Contributor

@alan alan commented on c49144b Aug 13, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teamon: I've got a fork of rack-test that fixes the issue, waiting to get it pulled into the main repo.

@threedaymonk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh. Should've been ☠.

@sandstrom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@nathankleyn
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP snowman. =[

@hauleth
Copy link

@hauleth hauleth commented on c49144b Dec 9, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a possibility to bring snowman back?

Please sign in to comment.