Permalink
Browse files

Checking blank if tag might coming nil or blank

In log it should not show the empty array.
  • Loading branch information...
1 parent af1b5c5 commit c495cbcda94bec7a49a88631fc575cc04bde8e88 @arunagw arunagw committed Oct 21, 2011
@@ -1,3 +1,4 @@
+require 'active_support/core_ext/object/blank'
require 'logger'
module ActiveSupport
@@ -18,7 +19,7 @@ def initialize(logger)
def tagged(*new_tags)
tags = current_tags
- new_tags = Array.wrap(new_tags).flatten
+ new_tags = Array.wrap(new_tags).flatten.reject(&:blank?)
tags.concat new_tags
yield
ensure
@@ -29,6 +29,11 @@ def flush(*)
assert_equal "[BCX] [Jason] [New] Funky time\n", @output.string
end
+ test "tagged once with blank and nil" do
+ @logger.tagged(nil, "", "New") { @logger.info "Funky time" }
+ assert_equal "[New] Funky time\n", @output.string
+ end
+
test "keeps each tag in their own thread" do
@logger.tagged("BCX") do
Thread.new do

0 comments on commit c495cbc

Please sign in to comment.