Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Remove deprecated method supports_primary_key?
  • Loading branch information
rafaelfranca committed Oct 23, 2017
1 parent 9438c14 commit c56ff22
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
4 changes: 4 additions & 0 deletions activerecord/CHANGELOG.md
@@ -1,3 +1,7 @@
* Remove deprecated method `supports_primary_key?`.

*Rafael Mendonça França*

* Remove deprecated method `supports_migrations?`.

*Rafael Mendonça França*
Expand Down
Expand Up @@ -196,11 +196,6 @@ def adapter_name
self.class::ADAPTER_NAME
end

def supports_primary_key? # :nodoc:
true
end
deprecate :supports_primary_key?

# Does this adapter support DDL rollbacks in transactions? That is, would
# CREATE TABLE or ALTER TABLE get rolled back by a transaction?
def supports_ddl_transactions?
Expand Down
4 changes: 0 additions & 4 deletions activerecord/test/cases/primary_keys_test.rb
Expand Up @@ -156,10 +156,6 @@ def test_instance_destroy_should_quote_pkey
assert_nothing_raised { MixedCaseMonkey.find(1).destroy }
end

def test_deprecate_supports_primary_key
assert_deprecated { ActiveRecord::Base.connection.supports_primary_key? }
end

def test_primary_key_returns_value_if_it_exists
klass = Class.new(ActiveRecord::Base) do
self.table_name = "developers"
Expand Down

0 comments on commit c56ff22

Please sign in to comment.