Remove deprecated method `supports_primary_key?`

rails · Oct 23, 2017 · c56ff22fc6e97df4656ddc22909d9bf8b0c2cbb1 · c56ff22
1 parent 9438c14
commit c56ff22fc6e97df4656ddc22909d9bf8b0c2cbb1
Unified Split

Showing with 4 additions and 9 deletions.

+4 −0 activerecord/CHANGELOG.md

+0 −5 activerecord/lib/active_record/connection_adapters/abstract_adapter.rb

+0 −4 activerecord/test/cases/primary_keys_test.rb
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md
@@ -1,3 +1,7 @@
+*   Remove deprecated method `supports_primary_key?`.
+
+    *Rafael Mendonça França*
+
 *   Remove deprecated method `supports_migrations?`.
 
     *Rafael Mendonça França*

diff --git a/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb b/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb
@@ -196,11 +196,6 @@ def adapter_name
         self.class::ADAPTER_NAME
       end
 
-      def supports_primary_key? # :nodoc:
-        true
-      end
-      deprecate :supports_primary_key?
-
       # Does this adapter support DDL rollbacks in transactions? That is, would
       # CREATE TABLE or ALTER TABLE get rolled back by a transaction?
       def supports_ddl_transactions?

diff --git a/activerecord/test/cases/primary_keys_test.rb b/activerecord/test/cases/primary_keys_test.rb
@@ -156,10 +156,6 @@ def test_instance_destroy_should_quote_pkey
     assert_nothing_raised { MixedCaseMonkey.find(1).destroy }
   end
 
-  def test_deprecate_supports_primary_key
-    assert_deprecated { ActiveRecord::Base.connection.supports_primary_key? }
-  end
-
   def test_primary_key_returns_value_if_it_exists
     klass = Class.new(ActiveRecord::Base) do
       self.table_name = "developers"