Permalink
Browse files

Replace snowman with utf8=✓

  • Loading branch information...
wycats committed Aug 12, 2010
1 parent 007c4da commit c6160898c83107ba63017ad2a8b3878733267136
@@ -538,7 +538,7 @@ def html_options_for_form(url_for_options, options, *parameters_for_url)
def extra_tags_for_form(html_options)
snowman_tag = tag(:input, :type => "hidden",

This comment has been minimized.

Show comment
Hide comment
@sikachu

sikachu Aug 12, 2010

Member

On this line you still call it snowman_tag :)

@sikachu

sikachu Aug 12, 2010

Member

On this line you still call it snowman_tag :)

- :name => "_e", :value => "☃".html_safe)
+ :name => "utf8", :value => "✓".html_safe)
method = html_options.delete("method").to_s
@@ -1513,7 +1513,7 @@ def test_form_for_with_labelled_builder
def snowman(method = nil)
txt = %{<div style="margin:0;padding:0;display:inline">}

This comment has been minimized.

Show comment
Hide comment
@dnch

dnch Aug 13, 2010

Why is this still here?

@dnch

dnch Aug 13, 2010

Why is this still here?

- txt << %{<input name="_e" type="hidden" value="&#9731;" />}
+ txt << %{<input name="utf8" type="hidden" value="&#x2713;" />}
txt << %{<input name="_method" type="hidden" value="#{method}" />} if method
txt << %{</div>}
end
@@ -12,7 +12,7 @@ def snowman(options = {})
method = options[:method]
txt = %{<div style="margin:0;padding:0;display:inline">}
- txt << %{<input name="_e" type="hidden" value="&#9731;" />}
+ txt << %{<input name="utf8" type="hidden" value="&#x2713;" />}
txt << %{<input name="_method" type="hidden" value="#{method}" />} if method
txt << %{</div>}
end

18 comments on commit c616089

@bbhoss

This comment has been minimized.

Show comment
Hide comment
@bbhoss

bbhoss Aug 12, 2010

Aww, I liked the snowman

Aww, I liked the snowman

@marcoow

This comment has been minimized.

Show comment
Hide comment
@marcoow

marcoow Aug 12, 2010

shouldn't it be

_utf8

just like

_method

?

shouldn't it be

_utf8

just like

_method

?

@sigerello

This comment has been minimized.

Show comment
Hide comment
@sigerello

sigerello Aug 12, 2010

+1 for _utf8

+1 for _utf8

@aaronchi

This comment has been minimized.

Show comment
Hide comment
@aaronchi

aaronchi Aug 12, 2010

Contributor

_utf8 = the first suggestion that actually makes sense +1

Contributor

aaronchi replied Aug 12, 2010

_utf8 = the first suggestion that actually makes sense +1

@sobrinho

This comment has been minimized.

Show comment
Hide comment
@sobrinho

sobrinho Aug 12, 2010

Contributor

+1 for _utf8 ;)

Contributor

sobrinho replied Aug 12, 2010

+1 for _utf8 ;)

@josevalim

This comment has been minimized.

Show comment
Hide comment
@josevalim

josevalim Aug 12, 2010

Contributor

Patch please. :)

Contributor

josevalim replied Aug 12, 2010

Patch please. :)

@sobrinho

This comment has been minimized.

Show comment
Hide comment
@sobrinho

sobrinho Aug 12, 2010

Contributor

I'm submiting the patch on Lighthouse ;)

Contributor

sobrinho replied Aug 12, 2010

I'm submiting the patch on Lighthouse ;)

@NARKOZ

This comment has been minimized.

Show comment
Hide comment
@NARKOZ

NARKOZ Aug 12, 2010

Contributor

RIP rails snowman

Contributor

NARKOZ replied Aug 12, 2010

RIP rails snowman

@scudco

This comment has been minimized.

Show comment
Hide comment
@scudco

scudco Aug 12, 2010

Contributor

As summer ends all snowmen slowly melt away. wait...

Contributor

scudco replied Aug 12, 2010

As summer ends all snowmen slowly melt away. wait...

@seban

This comment has been minimized.

Show comment
Hide comment
@seban

seban Aug 12, 2010

Snowman :( ...

Snowman :( ...

@teamon

This comment has been minimized.

Show comment
Hide comment
@teamon

teamon Aug 12, 2010

why, oh why?

why, oh why?

@madsheep

This comment has been minimized.

Show comment
Hide comment
@madsheep

madsheep Aug 13, 2010

This commit breakes a lot of things. Like my day and your sense of humor for instance ;)

This commit breakes a lot of things. Like my day and your sense of humor for instance ;)

@ream88

This comment has been minimized.

Show comment
Hide comment
@ream88

ream88 Aug 13, 2010

Contributor

Oh no :( RIP Snowman ...

Contributor

ream88 replied Aug 13, 2010

Oh no :( RIP Snowman ...

@madsheep

This comment has been minimized.

Show comment
Hide comment
@madsheep

madsheep Aug 13, 2010

Don't worry our snowman is back in later commits!

Don't worry our snowman is back in later commits!

@cmer

This comment has been minimized.

Show comment
Hide comment
@cmer

cmer Aug 13, 2010

+1 for _utf8

cmer replied Aug 13, 2010

+1 for _utf8

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 14, 2010

+1 for _utf8

+1 for _utf8

@sikachu

This comment has been minimized.

Show comment
Hide comment
@sikachu

sikachu Aug 14, 2010

Member

The _utf8 has already been fixed in latter commit: c49144b

Member

sikachu replied Aug 14, 2010

The _utf8 has already been fixed in latter commit: c49144b

Please sign in to comment.