Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Replace snowman with utf8=✓

  • Loading branch information...
commit c6160898c83107ba63017ad2a8b3878733267136 1 parent 007c4da
Yehuda Katz wycats authored
2  actionpack/lib/action_view/helpers/form_tag_helper.rb
View
@@ -538,7 +538,7 @@ def html_options_for_form(url_for_options, options, *parameters_for_url)
def extra_tags_for_form(html_options)
snowman_tag = tag(:input, :type => "hidden",
Prem Sichanugrist Collaborator
sikachu added a note

On this line you still call it snowman_tag :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
- :name => "_e", :value => "☃".html_safe)
+ :name => "utf8", :value => "✓".html_safe)
method = html_options.delete("method").to_s
2  actionpack/test/template/form_helper_test.rb
View
@@ -1513,7 +1513,7 @@ def test_form_for_with_labelled_builder
def snowman(method = nil)
txt = %{<div style="margin:0;padding:0;display:inline">}
Dan Cheail
dnch added a note

Why is this still here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
- txt << %{<input name="_e" type="hidden" value="&#9731;" />}
+ txt << %{<input name="utf8" type="hidden" value="&#x2713;" />}
txt << %{<input name="_method" type="hidden" value="#{method}" />} if method
txt << %{</div>}
end
2  actionpack/test/template/form_tag_helper_test.rb
View
@@ -12,7 +12,7 @@ def snowman(options = {})
method = options[:method]
txt = %{<div style="margin:0;padding:0;display:inline">}
- txt << %{<input name="_e" type="hidden" value="&#9731;" />}
+ txt << %{<input name="utf8" type="hidden" value="&#x2713;" />}
txt << %{<input name="_method" type="hidden" value="#{method}" />} if method
txt << %{</div>}
end

18 comments on commit c616089

Preston Marshall

Aww, I liked the snowman

Prem Sichanugrist

On this line you still call it snowman_tag :)

Marco Otte-Witte

shouldn't it be

_utf8

just like

_method

?

Oleksandr Sergiienko

+1 for _utf8

aaronchi

_utf8 = the first suggestion that actually makes sense +1

Gabriel Sobrinho

+1 for _utf8 ;)

José Valim
Owner

Patch please. :)

Gabriel Sobrinho

I'm submiting the patch on Lighthouse ;)

Nihad Abbasov

RIP rails snowman

Adam Anderson

As summer ends all snowmen slowly melt away. wait...

Sebastian Nowak

Snowman :( ...

Tymon Tobolski

why, oh why?

Marcin Stecki

This commit breakes a lot of things. Like my day and your sense of humor for instance ;)

Mario Uher

Oh no :( RIP Snowman ...

Marcin Stecki

Don't worry our snowman is back in later commits!

Carl Mercier

+1 for _utf8

Moonshine Agency Pty Ltd

+1 for _utf8

Prem Sichanugrist
Collaborator

The _utf8 has already been fixed in latter commit: c49144b

Please sign in to comment.
Something went wrong with that request. Please try again.