Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fix that scoped find with :group and :having [#2006 state:resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
  • Loading branch information...
commit c653f700d3afb1208b15fb7fec6250bf3a3f0321 1 parent dcd9c7f
@ffmike ffmike authored lifo committed
View
2  activerecord/lib/active_record/base.rb
@@ -1759,7 +1759,7 @@ def add_group!(sql, group, having, scope = :auto)
scope = scope(:find) if :auto == scope
if scope && (scoped_group = scope[:group])
sql << " GROUP BY #{scoped_group}"
- sql << " HAVING #{scoped_having}" if (scoped_having = scope[:having])
+ sql << " HAVING #{scope[:having]}" if scope[:having]
end
end
end
View
7 activerecord/test/cases/base_test.rb
@@ -1755,6 +1755,13 @@ def test_scoped_find_order_including_has_many_association
end
end
+ def test_scoped_find_with_group_and_having
+ developers = Developer.with_scope(:find => { :group => 'salary', :having => "SUM(salary) > 10000", :select => "SUM(salary) as salary" }) do
+ Developer.find(:all)
+ end
+ assert_equal 3, developers.size
+ end
+
def test_find_last
last = Developer.find :last
assert_equal last, Developer.find(:first, :order => 'id desc')
Please sign in to comment.
Something went wrong with that request. Please try again.