Skip to content
This repository
Browse code

Skip fetching path if the iteration is going to be skipped

  • Loading branch information...
commit c7ba4c7c9898fe4dae1f80d341c9cb1d5ef345d4 1 parent 5da8c16
Carlos Antonio da Silva carlosantoniodasilva authored

Showing 1 changed file with 2 additions and 2 deletions. Show diff stats Hide diff stats

  1. +2 2 actionpack/lib/action_controller/test_case.rb
4 actionpack/lib/action_controller/test_case.rb
@@ -42,13 +42,13 @@ def setup_subscriptions
42 42 end
43 43
44 44 ActiveSupport::Notifications.subscribe("!render_template.action_view") do |name, start, finish, id, payload|
45   - path = payload[:identifier]
46 45 next if payload[:virtual_path] # files don't have virtual path
  46 +
  47 + path = payload[:identifier]
47 48 if path
48 49 @_files[path] += 1
49 50 @_files[path.split("/").last] += 1
50 51 end
51   -
52 52 end
53 53 end
54 54

3 comments on commit c7ba4c7

Yasuo Honda

Recently rake test_oracle get this error some time. Not always, but let's say 1 of 5 times.

According to git bisect c7ba4c7 is the commit that causes this error. but not sure if it really causes this error.

  1) Error:
SchemaDumperTest#test_arguments_line_up:
RuntimeError: executing in another thread
    /home/yahonda/.rvm/gems/ruby-2.0.0-p0@railsmaster/gems/ruby-oci8-2.1.4/lib/oci8/cursor.rb:536:in `__fetch'
    /home/yahonda/.rvm/gems/ruby-2.0.0-p0@railsmaster/gems/ruby-oci8-2.1.4/lib/oci8/cursor.rb:536:in `fetch_one_row_as_array'
    /home/yahonda/.rvm/gems/ruby-2.0.0-p0@railsmaster/gems/ruby-oci8-2.1.4/lib/oci8/cursor.rb:149:in `fetch'
    /home/yahonda/.rvm/gems/ruby-2.0.0-p0@railsmaster/gems/ruby-oci8-2.1.4/lib/oci8/oci8.rb:292:in `exec_internal'
    /home/yahonda/.rvm/gems/ruby-2.0.0-p0@railsmaster/gems/ruby-oci8-2.1.4/lib/oci8/oci8.rb:279:in `exec'
    /home/yahonda/git/oracle-enhanced/lib/active_record/connection_adapters/oracle_enhanced_oci_connection.rb:438:in `ping'
    /home/yahonda/git/oracle-enhanced/lib/active_record/connection_adapters/oracle_enhanced_oci_connection.rb:72:in `ping'
    /home/yahonda/git/oracle-enhanced/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb:697:in `active?'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/connection_pool.rb:409:in `block (2 levels) in reap'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/connection_pool.rb:408:in `each'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/connection_pool.rb:408:in `block in reap'
    /home/yahonda/.rvm/rubies/ruby-2.0.0-p0/lib/ruby/2.0.0/monitor.rb:211:in `mon_synchronize'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/connection_pool.rb:406:in `reap'
    /home/yahonda/git/rails/activerecord/lib/active_record/connection_adapters/abstract/connection_pool.rb:217:in `block in run'

Any ideas?

Rafael Mendonça França
Owner

Hardly this commit is related with your failure since it is on action controller maybe is something related with the oci8 gem?

Yasuo Honda

Thanks for the comment. I'm going to test to see if it reproduces with jruby and JDBC driver.

Please sign in to comment.
Something went wrong with that request. Please try again.